New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Control.Lens.Cons from Data.Sequence.Lens #780

Open
treeowl opened this Issue Jan 8, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@treeowl
Contributor

treeowl commented Jan 8, 2018

I suspect most people who look into Data.Sequence.Lens will also want to know that Seq is an instance of Cons and of Snoc, and that they can therefore use various facilities in Control.Lens.Cons. I know re-exports are widely frowned upon, but I think it would pay to at least include a note in the documentation. Perhaps something like

Seq is an instance of Cons and of Snoc. This means you can use the prisms _Cons and _Snoc with sequences, along with the other functions in Control.Lens.Cons.

Unfortunately, my Haddock-fu is not very strong, so I don't know the right place/way to add that documentation. But I feel fairly strongly that it should go right at the top of the module.

@RyanGlScott

This comment has been minimized.

Show comment
Hide comment
@RyanGlScott

RyanGlScott Jan 8, 2018

Collaborator

I promise Haddock-fu isn't that hard to learn. Just put what you've typed out here! :)

Collaborator

RyanGlScott commented Jan 8, 2018

I promise Haddock-fu isn't that hard to learn. Just put what you've typed out here! :)

@wisn

This comment has been minimized.

Show comment
Hide comment
@wisn

wisn Mar 30, 2018

@RyanGlScott is this what you mean?

wisn commented Mar 30, 2018

@RyanGlScott is this what you mean?

@RyanGlScott

This comment has been minimized.

Show comment
Hide comment
@RyanGlScott

RyanGlScott Mar 30, 2018

Collaborator

@wisn, sure, that's the basic idea. Care to submit a pull request?

Collaborator

RyanGlScott commented Mar 30, 2018

@wisn, sure, that's the basic idea. Care to submit a pull request?

@wisn

This comment has been minimized.

Show comment
Hide comment
@wisn

wisn Mar 30, 2018

@RyanGlScott Yes, I'd. However, give me some moments to playing around with Haddock.

wisn commented Mar 30, 2018

@RyanGlScott Yes, I'd. However, give me some moments to playing around with Haddock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment