Added tuple swizzling lens TH #288

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Collaborator

jfischoff commented Mar 26, 2013

No description provided.

@jfischoff jfischoff closed this Mar 26, 2013

Collaborator

liyang commented Mar 26, 2013

You don't need to close and open a different ticket; just force-push your fixed commit to jfischoff:master. :octocat:
For what it's worth, I've replicated the screenfuls of errors with ghc-7.4.2; with 7.6.2 I only get one error for tests/templates.hs.

@liyang liyang reopened this Mar 26, 2013

Owner

ekmett commented Mar 26, 2013

I'm currently leaning towards pushing this patch off into 4.0. There are open issues about how we want to resolve things like the dependency on multiple Field instances, missing top level signatures, etc. and we were looking to push out 3.9 pretty much today.

Collaborator

jfischoff commented Mar 26, 2013

Agreed

Sent from my iPhone

On Mar 25, 2013, at 11:05 PM, Edward Kmett notifications@github.com wrote:

I'm currently leaning towards pushing this patch off into 4.0. There are open issues about how we want to resolve things like the dependency on multiple Field instances, missing top level signatures, etc. and we were looking to push out 3.9 pretty much today.


Reply to this email directly or view it on GitHub.

Collaborator

jfischoff commented Mar 26, 2013

Which is odd because I didn't get any errors with 7.6.2.

Sent from my iPhone

On Mar 25, 2013, at 10:54 PM, Liyang HU notifications@github.com wrote:

You don't need to close and open a different ticket; just force-push your fixed commit to jfischoff:master.
For what it's worth, I've replicated the screenfuls of errors with ghc-7.4.2; with 7.6.2 I only get one error for tests/templates.hs.


Reply to this email directly or view it on GitHub.

Owner

ekmett commented Mar 26, 2013

7.6.1 turns on NoMonomorphismRestriction in the REPL by default, changing doctest behavior.

Sent from my iPad

On Mar 26, 2013, at 9:45 AM, Jonathan Fischoff notifications@github.com wrote:

Which is odd because I didn't get any errors with 7.6.2.

Sent from my iPhone

On Mar 25, 2013, at 10:54 PM, Liyang HU notifications@github.com wrote:

You don't need to close and open a different ticket; just force-push your fixed commit to jfischoff:master.
For what it's worth, I've replicated the screenfuls of errors with ghc-7.4.2; with 7.6.2 I only get one error for tests/templates.hs.


Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub.

Collaborator

jfischoff commented Mar 26, 2013

I assumed that. But what I don't get is why I could compile at all in lens or in my own tuple-lenses package.

On Mar 26, 2013, at 9:52 AM, Edward Kmett notifications@github.com wrote:

7.6.1 turns on NoMonomorphismRestriction in the REPL by default, changing doctest behavior.

Sent from my iPad

On Mar 26, 2013, at 9:45 AM, Jonathan Fischoff notifications@github.com wrote:

Which is odd because I didn't get any errors with 7.6.2.

Sent from my iPhone

On Mar 25, 2013, at 10:54 PM, Liyang HU notifications@github.com wrote:

You don't need to close and open a different ticket; just force-push your fixed commit to jfischoff:master.
For what it's worth, I've replicated the screenfuls of errors with ghc-7.4.2; with 7.6.2 I only get one error for tests/templates.hs.


Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub.

Owner

ekmett commented Mar 27, 2013

Closing this out. Not sure why you are getting that build error, but I think the 'lensy' way forward would probably be to resurrect @mgsloan 's lense quasiquoter.

@ekmett ekmett closed this Mar 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment