Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alleviate manual XDebug config by using new Docker DNS name. #115

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@progonkpa
Copy link
Contributor

commented Oct 9, 2019

Removes the manual step of swapping out docker-host.localhost with your machine ip.

@eko
eko approved these changes Oct 9, 2019
@eko eko merged commit 34dba2b into eko:master Oct 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eko

This comment has been minimized.

Copy link
Owner

commented Oct 9, 2019

Thank you for fixing this @progonkpa

@progonkpa

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

I noticed that function variables were missing in the debugging locals panel. I fixed that by turning off opcache. I can make a pull request for that @eko but I'm not sure if it's a good solution: the loading times for a one line page is now 1.5 seconds instead of 0.5 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.