New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements for uploads #95

Merged
merged 2 commits into from Oct 27, 2018

Conversation

Projects
None yet
2 participants
@gritt
Contributor

gritt commented Oct 27, 2018

I was having some issues getting uploads working on symfony4, i've ended up discovering an issue that might affect certain versions of nginx over alpine.

dockerfile/nginx#4
https://wincent.com/wiki/Fixing_nginx_client_body_temp_permission_denied_errors

Adding these fixes for nginx, (set a writable tmp dir config), and also installing php7-fileinfo (symfony requirement) fixed completely my issues regarding file uploads in symfony4.

What do you guys think?

gritt added some commits Oct 27, 2018

@eko

eko approved these changes Oct 27, 2018

@eko

This comment has been minimized.

Owner

eko commented Oct 27, 2018

Hi @gritt,

I never encounter a use case that needs these parameters but it looks ok to be merged in the project: future users should not have issues about this configuration.

Thank you!

@eko eko merged commit b264e01 into eko:master Oct 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment