Jump to conversation
Unresolved conversations (1)
@Skarlso Skarlso Mar 18, 2022
We add in the bootstrap helper to get some of the environment properties to override scripts which can source the helper. This is so that we can help people migrate and ease the pain of transition.
pkg/nodebootstrap/userdata.go
Resolved conversations (9)
@Callisto13 Callisto13 Mar 29, 2022
perhaps just have the env var names, with a link to the script, rather than have the script inlined (a bit of overhead to reading)? i see value in both, so idk
Outdated
.../usage/nodegroup-override-announcement.md
Skarlso
@Callisto13 Callisto13 Mar 29, 2022
Is this script helpful? I cannot tell given you have said `helpX` only 3 times
Outdated
.../usage/nodegroup-override-announcement.md
Skarlso
@cPu1 cPu1 Mar 29, 2022
WDYT about this? ```suggestion eksctl now requires supplying an `overrideBootstrapCommand` for unmanaged nodegroups when using a custom AMI. <a class="md-button md-button--primary" href="/usage/nodegroup-override-announcement">Read more</a> ```
Outdated
userdocs/theme/main.html
@cPu1 cPu1 Mar 29, 2022
```suggestion API_SERVER_URL="${API_SERVER_URL}" ```
Outdated
.../usage/nodegroup-override-announcement.md
@cPu1 cPu1 Mar 29, 2022
Minor nit: ```suggestion Expect(api.ValidateNodeGroup(0, ng0)).To(MatchError(ContainSubstring("overrideBootstrapCommand is required when using a custom AMI "))) ```
Outdated
...pis/eksctl.io/v1alpha5/validation_test.go
@cPu1 cPu1 Mar 29, 2022
These policies are attached by default and are unrelated to using a custom AMI. To keep this example focused, we should remove this and consider adding another example demonstrating the `iam.attachPolicyARNs` feature. ```suggestion ```
Outdated
...ootstrap-command-unmanaged-nodegroup.yaml
@Callisto13 Callisto13 Mar 18, 2022
do we want to document what will be available from the helper script so they dont have to go read it?
.../usage/nodegroup-override-announcement.md
Skarlso
@Callisto13 Callisto13 Mar 18, 2022
```suggestion eksctl will no longer support unmanaged nodegroup custom AMIs with no bootstrap scripts. <a class="md-button md-button--primary" href="/usage/nodegroup-override-announcement">Read more</a> ```
Outdated
userdocs/theme/main.html
@aclevername aclevername Mar 18, 2022
do we have any example clusters in `examples/` that we should update (or remove and add a new example)?
Outdated
.../usage/nodegroup-override-announcement.md
Skarlso