diff --git a/components/script/dom/htmlinputelement.rs b/components/script/dom/htmlinputelement.rs
index 860d11eb22a12..bb57b065fec1f 100755
--- a/components/script/dom/htmlinputelement.rs
+++ b/components/script/dom/htmlinputelement.rs
@@ -1869,7 +1869,7 @@ impl HTMLInputElement {
let (chan, recv) = ipc::channel(self.global().time_profiler_chan().clone())
.expect("Error initializing channel");
let msg = FileManagerThreadMsg::SelectFiles(filter, chan, origin, opt_test_paths);
- let _ = resource_threads
+ resource_threads
.send(CoreResourceMsg::ToFileManager(msg))
.unwrap();
@@ -1896,7 +1896,7 @@ impl HTMLInputElement {
let (chan, recv) = ipc::channel(self.global().time_profiler_chan().clone())
.expect("Error initializing channel");
let msg = FileManagerThreadMsg::SelectFile(filter, chan, origin, opt_test_path);
- let _ = resource_threads
+ resource_threads
.send(CoreResourceMsg::ToFileManager(msg))
.unwrap();
@@ -2582,7 +2582,7 @@ impl VirtualMethods for HTMLInputElement {
{
if event.IsTrusted() {
let window = window_from_node(self);
- let _ = window
+ window
.task_manager()
.user_interaction_task_source()
.queue_event(
diff --git a/components/script/dom/mediasession.rs b/components/script/dom/mediasession.rs
index 7b5e1deb52943..40d4053c5fdd6 100644
--- a/components/script/dom/mediasession.rs
+++ b/components/script/dom/mediasession.rs
@@ -240,8 +240,7 @@ impl MediaSessionMethods for MediaSession {
if let Some(media_instance) = self.media_instance.get() {
media_instance.set_duration(state.duration.map(|v| *v).unwrap());
// If the playbackRate is not present or its value is null, set it to 1.0.
- let _ =
- media_instance.SetPlaybackRate(state.playbackRate.unwrap_or(Finite::wrap(1.0)))?;
+ media_instance.SetPlaybackRate(state.playbackRate.unwrap_or(Finite::wrap(1.0)))?;
// If the position is not present or its value is null, set it to zero.
media_instance.SetCurrentTime(state.position.unwrap_or(Finite::wrap(0.0)));
}
diff --git a/components/script/dom/webgl2renderingcontext.rs b/components/script/dom/webgl2renderingcontext.rs
index 7aadc4f5d64da..277ed939e45fb 100644
--- a/components/script/dom/webgl2renderingcontext.rs
+++ b/components/script/dom/webgl2renderingcontext.rs
@@ -4154,8 +4154,7 @@ impl WebGL2RenderingContextMethods for WebGL2RenderingContext {
constants::UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES => unsafe {
let values = values.iter().map(|&v| v as u32).collect::>();
rooted!(in(*cx) let mut result = ptr::null_mut::());
- let _ = Uint32Array::create(*cx, CreateWith::Slice(&values), result.handle_mut())
- .unwrap();
+ Uint32Array::create(*cx, CreateWith::Slice(&values), result.handle_mut()).unwrap();
ObjectValue(result.get())
},
constants::UNIFORM_BLOCK_REFERENCED_BY_VERTEX_SHADER |
@@ -4385,7 +4384,7 @@ impl WebGL2RenderingContextMethods for WebGL2RenderingContext {
));
rooted!(in(*cx) let mut rval = ptr::null_mut::());
- let _ = Int32Array::create(
+ Int32Array::create(
*cx,
CreateWith::Slice(&receiver.recv().unwrap()),
rval.handle_mut(),
diff --git a/components/script/dom/webglframebuffer.rs b/components/script/dom/webglframebuffer.rs
index 6818faeb8e354..d426f48f44231 100644
--- a/components/script/dom/webglframebuffer.rs
+++ b/components/script/dom/webglframebuffer.rs
@@ -982,7 +982,7 @@ impl WebGLFramebuffer {
impl Drop for WebGLFramebuffer {
fn drop(&mut self) {
- let _ = self.delete(Operation::Fallible);
+ self.delete(Operation::Fallible);
}
}
diff --git a/components/script/dom/webglrenderingcontext.rs b/components/script/dom/webglrenderingcontext.rs
index f96924e090f8a..228d4eef61bb1 100644
--- a/components/script/dom/webglrenderingcontext.rs
+++ b/components/script/dom/webglrenderingcontext.rs
@@ -2066,7 +2066,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
let format_ids = self.extension_manager.get_tex_compression_ids();
rooted!(in(*cx) let mut rval = ptr::null_mut::());
- let _ = Uint32Array::create(*cx, CreateWith::Slice(&format_ids), rval.handle_mut())
+ Uint32Array::create(*cx, CreateWith::Slice(&format_ids), rval.handle_mut())
.unwrap();
return ObjectValue(rval.get());
},
@@ -2165,7 +2165,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
let (sender, receiver) = webgl_channel().unwrap();
self.send_command(WebGLCommand::GetParameterInt2(param, sender));
rooted!(in(*cx) let mut rval = ptr::null_mut::());
- let _ = Int32Array::create(
+ Int32Array::create(
*cx,
CreateWith::Slice(&receiver.recv().unwrap()),
rval.handle_mut(),
@@ -2177,7 +2177,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
let (sender, receiver) = webgl_channel().unwrap();
self.send_command(WebGLCommand::GetParameterInt4(param, sender));
rooted!(in(*cx) let mut rval = ptr::null_mut::());
- let _ = Int32Array::create(
+ Int32Array::create(
*cx,
CreateWith::Slice(&receiver.recv().unwrap()),
rval.handle_mut(),
@@ -2194,7 +2194,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
let (sender, receiver) = webgl_channel().unwrap();
self.send_command(WebGLCommand::GetParameterFloat2(param, sender));
rooted!(in(*cx) let mut rval = ptr::null_mut::());
- let _ = Float32Array::create(
+ Float32Array::create(
*cx,
CreateWith::Slice(&receiver.recv().unwrap()),
rval.handle_mut(),
@@ -2206,7 +2206,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
let (sender, receiver) = webgl_channel().unwrap();
self.send_command(WebGLCommand::GetParameterFloat4(param, sender));
rooted!(in(*cx) let mut rval = ptr::null_mut::());
- let _ = Float32Array::create(
+ Float32Array::create(
*cx,
CreateWith::Slice(&receiver.recv().unwrap()),
rval.handle_mut(),
@@ -3380,7 +3380,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
let value = [x, y, z, w];
unsafe {
rooted!(in(*cx) let mut result = ptr::null_mut::());
- let _ = Float32Array::create(
+ Float32Array::create(
*cx,
CreateWith::Slice(&value),
result.handle_mut(),
@@ -3393,12 +3393,8 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
let value = [x, y, z, w];
unsafe {
rooted!(in(*cx) let mut result = ptr::null_mut::());
- let _ = Int32Array::create(
- *cx,
- CreateWith::Slice(&value),
- result.handle_mut(),
- )
- .unwrap();
+ Int32Array::create(*cx, CreateWith::Slice(&value), result.handle_mut())
+ .unwrap();
return ObjectValue(result.get());
}
},
@@ -3406,7 +3402,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
let value = [x, y, z, w];
unsafe {
rooted!(in(*cx) let mut result = ptr::null_mut::());
- let _ = Uint32Array::create(
+ Uint32Array::create(
*cx,
CreateWith::Slice(&value),
result.handle_mut(),
diff --git a/components/script/dom/window.rs b/components/script/dom/window.rs
index d6c7687832f98..c03903e9199c5 100644
--- a/components/script/dom/window.rs
+++ b/components/script/dom/window.rs
@@ -783,7 +783,7 @@ impl WindowMethods for Window {
// which calls into https://html.spec.whatwg.org/multipage/#discard-a-document.
window.discard_browsing_context();
- let _ = window.send_to_constellation(ScriptMsg::DiscardTopLevelBrowsingContext);
+ window.send_to_constellation(ScriptMsg::DiscardTopLevelBrowsingContext);
}
});
self.task_manager()
diff --git a/components/script/script_module.rs b/components/script/script_module.rs
index 5c9151fd3aa8a..05427b516d471 100644
--- a/components/script/script_module.rs
+++ b/components/script/script_module.rs
@@ -1684,7 +1684,7 @@ fn fetch_single_module_script(
match document {
Some(doc) => doc.fetch_async(LoadType::Script(url), request, action_sender),
None => {
- let _ = global
+ global
.resource_threads()
.sender()
.send(CoreResourceMsg::Fetch(