From 9592241d629a9005d74925368baa70ca4fc6eeb8 Mon Sep 17 00:00:00 2001 From: Jeremie Bonal Date: Fri, 6 Jan 2017 14:55:11 +0100 Subject: [PATCH] Better amount/balance comparison in Letterable#letterable_items --- app/models/concerns/letterable.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/concerns/letterable.rb b/app/models/concerns/letterable.rb index 481bdbcd3f..bb84f8dd3c 100644 --- a/app/models/concerns/letterable.rb +++ b/app/models/concerns/letterable.rb @@ -36,8 +36,8 @@ def letterable_items(bank_statement_items) return false unless mode.cash_id == bank_statement.cash_id items = BankStatementItem.where(id: bank_statement_items) - bank_items_balance = items.sum(:debit) - items.sum(:credit) - return false unless -relative_amount == bank_items_balance + bank_items_balance = items.sum(:credit) - items.sum(:debit) + return false unless relative_amount == bank_items_balance items end end