Zip Import to Experiments missing Attachements, Steps, Linked Items, Comments

[m6121]

Describe the bug

Imports of Experiments by using the ZIP archives is missing attachments, steps, linked items and comments.

Steps to reproduce

1. Create an experiment, add an attachment to it, create steps etc.
2. Export the experiment as ZIP: Actually the ZIP respecitvely JSON file contain not all information. While attachment information are contained, those of linked items are missing, only the next step is contained in verbatim text and the count of comments is contained.
3. Import the ZIP into another Team. This shows only the body, tags and title of the imported experiment.

Information

• Version of eLabFTW (visible in Sysadmin panel): 3.3.12
• Operating system (e.g. GNU+Linux/MacOS/Windows): Linux
• Browser (e.g. firefox, chrome): Firefox+Chrome

[NicolasCARPi]

Hello,

Yes indeed. For the uploaded file, it's a bug that I have now fixed. For the steps and links there was never any code to do that anyway so this would need to get added.

Thanks for the report!

[NicolasCARPi]

If you need to monkey patch your system, here is the commit to fix files not getting uploaded: af3da54

This change will be part of the 3.4.0 version.

[NicolasCARPi]

I added the code for importing steps and links. But for links, let's say you are reimporting your experiments to another database, the links id will be wrong, so it doesn't make sense to redo the links like they were before. So they are added at the bottom of the body of the experiment as text.

[m6121]

Thanks a lot for the fast bug fixing and implementation!

[T-Luyten]

In addition to the missing items above, imports of experiments by zip folder also don't keep their locked state or timestamps. Also the status of the experiment is not retained.

[NicolasCARPi]

The status is not retained because status are editable (so you can't expect to have the same everywhere). But maybe adding a status select in the import UI would be good for experiments. As for locking I prefer to leave it like that, because the locking mechanism needs a userid as locker, and when you import it could be from a totally different database, so it doesn't make sense imho to keep the locked state.