Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the tinyMCE mention plugin #4852

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Fix the tinyMCE mention plugin #4852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
308b72b
make it work again
MarcelBolten Jan 14, 2024
8ffec10
Fix typos
MarcelBolten Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/js/tinymce-plugins/mention/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,24 @@ class AutoComplete {

this.query = '';
this.hasFocus = true;
// joiner should be an invisible character and functions as glue between delimiter and search text typed by user
// compare to https://stackoverflow.com/a/28405917 for potential characters
// e.g. \uFEF, \u2007, \u202F, \u2060, \u200B
// \uFEFF can not be used any longer as of tinymce version 5.10.9 - 2023-11-14 and 6.7.3 - 2023-11-15
this.joiner = '\u2060';

this.renderInput();

this.bindEvents();

}

renderInput() {
// for some reason the id attribute of the first span gets removed during insert, so we use a data attribute instead
const rawHtml = `<span data-tiny-complete="1"><span id="autocomplete-delimiter">${this.options.delimiter}</span>
<span data-tiny-complete-searchtext="1"><span class="dummy">\uFEFF</span></span></span>`;
// for some reason the id attribute of the first span gets removed during insert, so we use a data attribute instead
// don't add any additional characters that would be part of rawHtml.innerText unless it is reflected in the lookup method
const rawHtml = '<span data-tiny-complete="1">'
+ `<span id="autocomplete-delimiter">${this.options.delimiter}</span>`
+ `<span data-tiny-complete-searchtext="1"><span class="dummy">${this.joiner}</span></span>`
+ '</span>';
this.editor.execCommand('mceInsertContent', false, rawHtml);
this.editor.focus();
this.editor.selection.select(this.editor.selection.dom.select('span[data-tiny-complete-searchtext="1"] span')[0]);
Expand Down Expand Up @@ -146,7 +153,8 @@ class AutoComplete {
}

lookup() {
this.query = this.editor.getBody().querySelector('[data-tiny-complete="1"]').textContent.replace('# ', '');
// the text to be replaced has to match exactly what would be the result of rawHtml.innerText of the renderInput method
this.query = this.editor.getBody().querySelector('[data-tiny-complete="1"]').innerText.replace(`${this.options.delimiter}${this.joiner}`, '');

if (this.$dropdown === undefined) {
this.show();
Expand Down