Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META 359] Consolidate server_url/server_urls option #1035

Closed
AlexanderWert opened this issue Nov 12, 2020 · 1 comment · Fixed by #1065
Closed

[META 359] Consolidate server_url/server_urls option #1035

AlexanderWert opened this issue Nov 12, 2020 · 1 comment · Fixed by #1065
Assignees
@russcam
Labels
agent-dotnet cross APM agents
Projects
APM-Agents (OLD)
Milestone
7.11

Comments

@AlexanderWert
Copy link
Member

Rename server_urls to server_url (see elastic/apm#359) in a backwards compatible way.

Adapt documentation to only describe the server_url option.
@AlexanderWert AlexanderWert added this to the 7.11 milestone Nov 12, 2020
@AlexanderWert AlexanderWert added this to Planned in APM-Agents (OLD) via automation Nov 12, 2020
@AlexanderWert AlexanderWert changed the title Consolidate server_url/server_urls option [META 359] Consolidate server_url/server_urls option Nov 25, 2020
@AlexanderWert AlexanderWert mentioned this issue Nov 25, 2020
Closed
@russcam russcam self-assigned this Nov 30, 2020
@russcam russcam moved this from Planned to In Progress in APM-Agents (OLD) Nov 30, 2020
russcam added a commit to russcam/apm-agent-dotnet that referenced this issue Nov 30, 2020
@russcam
Introduce ServerUrl and deprecate ServerUrls
b0a0bad 
This commit consolidates ServerUrl and ServerUrls options
by

- introducing ServerUrl configuration value
- deprecating ServerUrls with ObsoleteAttribute

ServerUrl uses the ServerUrl environment or setting key value,
falling back to ServerUrls[0] when not specified, allowing
the usage of ServerUrls to continue to work.

ServerUrls uses the ServerUrls environment or setting key value
if specified, falling back to ServerUrl environment or setting key value
when not specified, allowing exitsing usage of ServerUrls outside of the
agent API to work with ServerUrl.

Closes elastic#1035
@russcam russcam mentioned this issue Nov 30, 2020
Merged
@russcam
Copy link
Contributor

russcam commented Nov 30, 2020

Opened #1065 to address

APM-Agents (OLD) automation moved this from In Progress to Done Dec 1, 2020
russcam added a commit that referenced this issue Dec 1, 2020
@russcam
Introduce ServerUrl and deprecate ServerUrls (#1065)
79f886a 
This commit consolidates ServerUrl and ServerUrls options by

- introducing ServerUrl configuration value
- deprecating ServerUrls with ObsoleteAttribute

ServerUrl uses the ServerUrl environment or setting key value,
falling back to ServerUrls[0] when not specified, allowing
the usage of ServerUrls to continue to work.

ServerUrls uses the ServerUrls environment or setting key value
if specified, falling back to ServerUrl environment or setting key value
when not specified, allowing exitsing usage of ServerUrls outside of the
agent API to work with ServerUrl.

Log info level deprecation message when ServerUrls is used.

Closes #1035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@russcam russcam

Labels
agent-dotnet cross APM agents
Projects
APM-Agents (OLD)
  
Done
Milestone
7.11
Development

Successfully merging a pull request may close this issue.

Introduce ServerUrl and deprecate ServerUrls russcam/apm-agent-dotnet
2 participants
@russcam @AlexanderWert