Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexport all of Tracer's fields #1219

Merged
merged 3 commits into from Feb 24, 2022
Merged

Conversation

axw
Copy link
Member

@axw axw commented Feb 24, 2022

All options should be set at construction time, and should be immutable there on.

This used to be safe when the Tracer did not actively make requests to APM Server until events were enqueued, but this is no longer the case.

@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Feb 24, 2022
@axw axw marked this pull request as draft February 24, 2022 05:06
All options should be set at construction
time, and should be immutable there on.
@apmmachine
Copy link
Collaborator

apmmachine commented Feb 24, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-24T05:30:22.249+0000

  • Duration: 42 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 8328
Skipped 201
Total 8529

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@axw axw marked this pull request as ready for review February 24, 2022 05:26
@axw axw requested a review from a team February 24, 2022 05:28
CHANGELOG.asciidoc Show resolved Hide resolved
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@axw axw merged commit 0200192 into elastic:main Feb 24, 2022
APM-Agents (OLD) automation moved this from In Progress to Done Feb 24, 2022
@axw axw deleted the unexpose-tracer-fields branch February 24, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants