Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update redigo to v1.8.2 as v2.0.0 is too old #807

Merged
merged 1 commit into from Aug 27, 2020
Merged

Update redigo to v1.8.2 as v2.0.0 is too old #807

merged 1 commit into from Aug 27, 2020

Conversation

billyplus
Copy link
Contributor

What does this PR do?

According to Issue:

2.0 is old, it was created as a new feature set but didn't make much progress. It's only been kept for compatibility for those that tried it.
So in summary use 1.X (master) which is being actively supported.

Why is it important?

v2.0.0 is outdated, last commit is on Mar 15, 2018.

@cla-checker-service
Copy link

cla-checker-service bot commented Aug 27, 2020 •
edited

💚 CLA has been signed

@apmmachine
Copy link
Collaborator

apmmachine commented Aug 27, 2020 •
edited

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [axw commented: jenkins run the tests please]

  • Start Time: 2020-08-27T06:50:23.490+0000

  • Duration: 9 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 4779
Skipped 135
Total 4914

Steps errors

Expand to view the steps failures

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 2 min 8 sec

    • Start Time: 2020-08-27T06:55:17.760+0000

    • log

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 0 min 5 sec

    • Start Time: 2020-08-27T06:57:25.819+0000

    • log

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 0 min 5 sec

    • Start Time: 2020-08-27T06:57:30.685+0000

    • log

  • Name: Error signal

    • Description:

    • Duration: 0 min 0 sec

    • Start Time: 2020-08-27T06:57:35.560+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-08-27T06:59:28.564Z] --- PASS: TestFilesystemContextSetter (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestFilesystemContextSetterFileNotFound
[2020-08-27T06:59:28.564Z] --- PASS: TestFilesystemContextSetterFileNotFound (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestLibraryPackage
[2020-08-27T06:59:28.564Z] --- PASS: TestLibraryPackage (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestStacktrace
[2020-08-27T06:59:28.564Z] --- PASS: TestStacktrace (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestSplitFunctionName
[2020-08-27T06:59:28.564Z] --- PASS: TestSplitFunctionName (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestSplitFunctionNameUnescape
[2020-08-27T06:59:28.564Z] --- PASS: TestSplitFunctionNameUnescape (0.00s)
[2020-08-27T06:59:28.564Z] PASS
[2020-08-27T06:59:28.564Z] ok  	go.elastic.co/apm/stacktrace	0.006s
[2020-08-27T06:59:28.564Z] === RUN   TestInitDefault
[2020-08-27T06:59:28.564Z] --- PASS: TestInitDefault (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestInitDefaultDiscard
[2020-08-27T06:59:28.564Z] --- PASS: TestInitDefaultDiscard (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestInitDefaultError
[2020-08-27T06:59:28.564Z] --- PASS: TestInitDefaultError (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestNewHTTPTransportDefaultURL
[2020-08-27T06:59:28.564Z] --- PASS: TestNewHTTPTransportDefaultURL (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportUserAgent
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportUserAgent (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportSecretToken
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportSecretToken (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportEnvSecretToken
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportEnvSecretToken (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportAPIKey
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportAPIKey (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportEnvAPIKey
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportEnvAPIKey (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportNoAuthorization
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportNoAuthorization (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportTLS
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportTLS (0.05s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportEnvVerifyServerCert
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportEnvVerifyServerCert (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPError
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPError (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportContent
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportContent (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportServerTimeout
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportServerTimeout (0.05s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportServerFailover
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportServerFailover (0.01s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportV2NotFound
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportV2NotFound (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportServerCert
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportServerCert (0.01s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportServerCertInvalid
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportServerCertInvalid (0.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportWatchConfig
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportWatchConfig (1.00s)
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportWatchConfigQueryParams
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportWatchConfigQueryParams/name_only
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportWatchConfigQueryParams/name_and_env
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportWatchConfigQueryParams/name_empty
[2020-08-27T06:59:28.564Z] === RUN   TestHTTPTransportWatchConfigQueryParams/both_empty
[2020-08-27T06:59:28.564Z] --- PASS: TestHTTPTransportWatchConfigQueryParams (4.01s)
[2020-08-27T06:59:28.564Z]     --- PASS: TestHTTPTransportWatchConfigQueryParams/name_only (1.00s)
[2020-08-27T06:59:28.564Z]     --- PASS: TestHTTPTransportWatchConfigQueryParams/name_and_env (1.00s)
[2020-08-27T06:59:28.565Z]     --- PASS: TestHTTPTransportWatchConfigQueryParams/name_empty (1.00s)
[2020-08-27T06:59:28.565Z]     --- PASS: TestHTTPTransportWatchConfigQueryParams/both_empty (1.00s)
[2020-08-27T06:59:28.565Z] === RUN   TestHTTPTransportWatchConfigContextCancelled
[2020-08-27T06:59:28.565Z] --- PASS: TestHTTPTransportWatchConfigContextCancelled (0.00s)
[2020-08-27T06:59:28.565Z] === RUN   TestNewHTTPTransportTrailingSlash
[2020-08-27T06:59:28.565Z] --- PASS: TestNewHTTPTransportTrailingSlash (0.00s)
[2020-08-27T06:59:28.565Z] === RUN   TestHTTPTransportSendProfile
[2020-08-27T06:59:28.565Z] --- PASS: TestHTTPTransportSendProfile (0.00s)
[2020-08-27T06:59:28.565Z] PASS
[2020-08-27T06:59:28.565Z] ok  	go.elastic.co/apm/transport	5.159s
[2020-08-27T06:59:28.565Z] ?   	go.elastic.co/apm/transport/transporttest	[no test files]
[2020-08-27T06:59:28.565Z] + status=0
[2020-08-27T06:59:28.565Z] + go get -v -u github.com/jstemmer/go-junit-report
[2020-08-27T06:59:28.565Z] go: finding github.com/jstemmer/go-junit-report v0.9.1
[2020-08-27T06:59:28.565Z] go: downloading github.com/jstemmer/go-junit-report v0.9.1
[2020-08-27T06:59:28.565Z] go: extracting github.com/jstemmer/go-junit-report v0.9.1
[2020-08-27T06:59:28.565Z] github.com/jstemmer/go-junit-report/parser
[2020-08-27T06:59:28.565Z] github.com/jstemmer/go-junit-report/formatter
[2020-08-27T06:59:28.565Z] github.com/jstemmer/go-junit-report
[2020-08-27T06:59:28.565Z] + go-junit-report
[2020-08-27T06:59:28.565Z] + exit 0
[2020-08-27T06:59:28.626Z] Recording test results
[2020-08-27T06:59:30.268Z] Stage "Coverage" skipped due to earlier failure(s)
[2020-08-27T06:59:30.302Z] Stage "Benchmark" skipped due to earlier failure(s)
[2020-08-27T06:59:30.371Z] Stage "More OS" skipped due to earlier failure(s)
[2020-08-27T06:59:30.403Z] Stage "Windows" skipped due to earlier failure(s)
[2020-08-27T06:59:30.405Z] Stage "OSX" skipped due to earlier failure(s)
[2020-08-27T06:59:30.433Z] Failed in branch Windows
[2020-08-27T06:59:30.434Z] Failed in branch OSX
[2020-08-27T06:59:30.483Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-08-27T06:59:30.514Z] Stage "Release" skipped due to earlier failure(s)
[2020-08-27T06:59:30.530Z] Stage "Release" skipped due to earlier failure(s)
[2020-08-27T06:59:30.750Z] Running on Jenkins in /var/lib/jenkins/workspace/agent-go_apm-agent-go-mbp_PR-807
[2020-08-27T06:59:30.836Z] [INFO] getVaultSecret: Getting secrets
[2020-08-27T06:59:30.917Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-08-27T06:59:31.561Z] + chmod 755 generate-build-data.sh
[2020-08-27T06:59:31.561Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-807/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-807/runs/2 FAILURE 547811
[2020-08-27T06:59:32.112Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-807/runs/2/steps/?limit=10000 -o steps-info.json
[2020-08-27T06:59:32.662Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-807/runs/2/tests/?status=FAILED -o tests-errors.json

@axw
Copy link
Member

axw commented Aug 27, 2020

Thanks @billyplus! Fortunately there's no API breakage, so it looks like this will be straightforward. Can you please sign the CLA?

@billyplus
Copy link
Contributor Author

ok, i had signed the CLA.

@axw
Copy link
Member

axw commented Aug 27, 2020

jenkins run the tests please

@axw
Copy link
Member

axw commented Aug 27, 2020

Test failure is unrelated, I'll fix that later.

Thanks again @billyplus

@axw axw merged commit 991bfb9 into elastic:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@billyplus @apmmachine @axw