Prefer w3c traceparent header over legacy elastic-apm-traceparent #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the order of precedence, preferring the W3C 'traceparent' header over 'elastic-apm-traceparent'.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
May 28, 2021
module/apmot/tracer.go
Outdated
| // the value if not set already. | ||
| traceparentHeaderValue = val | ||
| case apmhttp.ElasticTraceparentHeader: | ||
| // The W3C header value always trumps the ElastiC one, |
There was a problem hiding this comment.
Liking the stylized ElastiC
axw
commented
May 28, 2021
Merged
stuartnelson3
pushed a commit
that referenced
this pull request
Jul 30, 2021
* Give precedence to W3C 'traceparent' header Switch the order of precedence, preferring the W3C 'traceparent' header over 'elastic-apm-traceparent'. * Update changelog * Update module/apmot/tracer.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the order of precedence, preferring the W3C 'traceparent' header over 'elastic-apm-traceparent'.
See elastic/apm#442