Use JSP name for JSP-transactions instead of servlet name

[eyalkoren]

For example- GET TobBar.jsp and POST TopBar.jsp instead of TopBar_jsp#doGet and TopBar_jsp#doPost

Hi @eyalkoren
Here we should take login.jsp name or login.do?

@WebServlet(urlPatterns = "/login.do")
public class LoginServlet extends HttpServlet {

    LoginService loginService = new LoginService();
    TodoService todoService = new TodoService();

    @Override
    protected void doGet(HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException {
        RequestDispatcher requestDispatcher = request.getRequestDispatcher("/WEB-INF/views/login.jsp");
        requestDispatcher.forward(request, response);
    }
...

[eyalkoren]

Great question! As a user I would expect the transaction to be named login.do, as this reflects the end user action. It may indeed be nice if we have a span for login.jsp in this case (e.g. by instrumenting RequestDispatcher.forward) to tell the complete server side story.
I went to see what we are doing now in

apm-agent-java/apm-agent-plugins/apm-servlet-plugin/src/test/java/co/elastic/apm/agent/servlet/ServletInstrumentationTest.java

Line 85 in d83d37b

void testForward() throws Exception {

and it seems we get it wrong- we name the transaction based on the forwarded servlet and not the first one to handle the request. That's because we set the name when the first Servlet.service method is exited in

apm-agent-java/apm-agent-plugins/apm-servlet-plugin/src/main/java/co/elastic/apm/agent/servlet/ServletApiAdvice.java

Line 141 in d83d37b

ServletTransactionHelper.setTransactionNameByServletClass(httpServletRequest.getMethod(), thiz.getClass(), currentTransaction.getName());

I'd consider this a bug. Would you like to handle the entire thing?

yeah, let me take a look at it.

Hi @eyalkoren
i added instrumentation for forward, and include methods. I didn't find way to get path from getRequestDispatcher(String path) .

[eyalkoren]

related to #384

[eyalkoren]

@nugusbayevkk sorry for the delayed response. Can you use FORWARD_SERVLET_PATH, FORWARD_PATH_INFO, INCLUDE_SERVLET_PATH and INCLUDE_PATH_INFO request attributes to get the target path?

@eyalkoren , thanks, i will try using it.