Skip to content

Conversation

@felixbarny
Copy link
Member

@felixbarny felixbarny commented May 12, 2020

attempt to fix #1178

@codecov-io
Copy link

Codecov Report

Merging #1179 into master will decrease coverage by 4.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1179      +/-   ##
============================================
- Coverage     64.05%   59.67%   -4.38%     
+ Complexity     2794       83    -2711     
============================================
  Files           282      328      +46     
  Lines         13609    15020    +1411     
  Branches       1874     2089     +215     
============================================
+ Hits           8717     8963     +246     
- Misses         4305     5447    +1142     
- Partials        587      610      +23     
Impacted Files Coverage Δ Complexity Δ
...nt/configuration/converter/ListValueConverter.java 43.47% <0.00%> (-39.86%) 0.00% <0.00%> (-4.00%)
...ration/source/PropertyFileConfigurationSource.java 30.26% <0.00%> (-35.46%) 0.00% <0.00%> (-10.00%)
...tion/source/SystemPropertyConfigurationSource.java 23.07% <0.00%> (-26.93%) 0.00% <0.00%> (-3.00%)
...c/main/java/co/elastic/apm/agent/util/IOUtils.java 44.08% <0.00%> (-19.98%) 0.00% <0.00%> (-10.00%)
.../agent/hibernate/search/HibernateSearchHelper.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...m/agent/kafka/BaseKafkaHeadersInstrumentation.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...Mule4OverrideClassLoaderLookupInstrumentation.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...pentracing/impl/ApmSpanBuilderInstrumentation.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...ava/co/elastic/apm/opentracing/ElasticApmTags.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...gent/opentracing/impl/ApmScopeInstrumentation.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3882444...3466965. Read the comment docs.

@ghost
Copy link

ghost commented May 12, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 1263
Skipped 12
Total 1275

@felixbarny felixbarny merged commit a0fd551 into elastic:master May 12, 2020
@felixbarny felixbarny mentioned this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky gRPC test

2 participants