Skip to content

Use synchronized lists in MockReporter #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020
Merged

Use synchronized lists in MockReporter #1179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ public class MockReporter implements Reporter {
// And for any case the disablement of the check cannot rely on subtype (eg Redis, where Jedis supports and Lettuce does not)
private boolean disableDestinationAddressCheck;

private final List<Transaction> transactions = new ArrayList<>();
private final List<Span> spans = new ArrayList<>();
private final List<ErrorCapture> errors = new ArrayList<>();
private final List<Transaction> transactions = Collections.synchronizedList(new ArrayList<>());
private final List<Span> spans = Collections.synchronizedList(new ArrayList<>());
private final List<ErrorCapture> errors = Collections.synchronizedList(new ArrayList<>());
private final ObjectMapper objectMapper;
private final boolean verifyJsonSchema;
private boolean closed;
Expand Down