Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace System Rules with System Lambda #1434

Merged
merged 1 commit into from Oct 13, 2020
Merged

Replace System Rules with System Lambda #1434

merged 1 commit into from Oct 13, 2020

Conversation

stefanbirkner
Copy link
Contributor

System Lambda is independent of the test framework while System Rules is
build for JUnit 4. We are using JUnit Jupiter and therefore System
Lambda is the better choice.

In addition System Lambda is more precise. It allows to set environment
variables for a single statement only. This already improves the
readability of the test because you can now immediately see which
environment variables are set when SystemInfo#findContainerDetails is
executed.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@cla-checker-service
Copy link

cla-checker-service bot commented Oct 9, 2020

💚 CLA has been signed

System Lambda is independent of the test framework while System Rules is
build for JUnit 4. We are using JUnit Jupiter and therefore System
Lambda is the better choice.

In addition System Lambda is more precise. It allows to set environment
variables for a single statement only. This already improves the
readability of the test because you can now immediately see which
environment variables are set when SystemInfo#findContainerDetails is
executed.
@apmmachine
Copy link
Collaborator

apmmachine commented Oct 9, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user eyalkoren, Replayed #2]

  • Start Time: 2020-10-11T05:59:42.369+0000

  • Duration: 45 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 1610
Skipped 12
Total 1622

@eyalkoren
Copy link
Contributor

eyalkoren commented Oct 11, 2020

@stefanbirkner Thanks!!
Please sign the CLA with your GitHub email, so that I can merge your changes.
Running tests in the mean time.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@2259495). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1434   +/-   ##
=========================================
  Coverage          ?   59.82%           
  Complexity        ?       91           
=========================================
  Files             ?      387           
  Lines             ?    17460           
  Branches          ?     2396           
=========================================
  Hits              ?    10445           
  Misses            ?     6299           
  Partials          ?      716           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2259495...4a591ad. Read the comment docs.

@eyalkoren eyalkoren merged commit 8e87e2a into elastic:master Oct 13, 2020
@stefanbirkner stefanbirkner deleted the system-lambda branch October 18, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants