Skip to content

Conversation

@SylvainJuge
Copy link
Member

What does this PR do?

  • do not prompt for Yes/No if version change is required
  • directly prompt for the target release version (with default derived from current -SNAPSHOT project version)
  • do not call mvn nor try to push any git commit if not required to (fails as there is nothing to push otherwise).

@SylvainJuge SylvainJuge added the automation Tests & automation that help build & maintain the project label May 28, 2021
@SylvainJuge SylvainJuge requested a review from cachedout May 28, 2021 14:22
Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes total sense. Nicely done!

@SylvainJuge SylvainJuge merged commit 12dda45 into elastic:master May 28, 2021
@SylvainJuge SylvainJuge deleted the fix-release-version-prompt branch May 28, 2021 14:36
@ghost
Copy link

ghost commented May 28, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1830 opened

  • Start Time: 2021-05-28T14:18:23.375+0000

  • Duration: 53 min 39 sec

  • Commit: cf0fc8b

Test stats 🧪

Test Results
Failed 0
Passed 2188
Skipped 18
Total 2206

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2188
Skipped 18
Total 2206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java automation Tests & automation that help build & maintain the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants