From d77ba434921ab8aca61afef57993294e8b8fac59 Mon Sep 17 00:00:00 2001 From: eyalkoren <41850454+eyalkoren@users.noreply.github.com> Date: Wed, 8 Dec 2021 10:22:10 +0200 Subject: [PATCH] Switch to using Span concurrent weak map in Vert.x 3 --- .../java/co/elastic/apm/agent/vertx/v3/web/WebHelper.java | 4 ++-- .../v3/web/http1/HttpServerRequestImplEndInstrumentation.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apm-agent-plugins/apm-vertx/apm-vertx3-plugin/src/main/java/co/elastic/apm/agent/vertx/v3/web/WebHelper.java b/apm-agent-plugins/apm-vertx/apm-vertx3-plugin/src/main/java/co/elastic/apm/agent/vertx/v3/web/WebHelper.java index 5abd9da776..fde1183b7b 100644 --- a/apm-agent-plugins/apm-vertx/apm-vertx3-plugin/src/main/java/co/elastic/apm/agent/vertx/v3/web/WebHelper.java +++ b/apm-agent-plugins/apm-vertx/apm-vertx3-plugin/src/main/java/co/elastic/apm/agent/vertx/v3/web/WebHelper.java @@ -18,10 +18,10 @@ */ package co.elastic.apm.agent.vertx.v3.web; +import co.elastic.apm.agent.collections.WeakConcurrentProviderImpl; import co.elastic.apm.agent.impl.ElasticApmTracer; import co.elastic.apm.agent.impl.GlobalTracer; import co.elastic.apm.agent.impl.transaction.Transaction; -import co.elastic.apm.agent.sdk.weakconcurrent.WeakConcurrent; import co.elastic.apm.agent.sdk.weakconcurrent.WeakMap; import co.elastic.apm.agent.vertx.AbstractVertxWebHelper; import io.vertx.core.Handler; @@ -34,7 +34,7 @@ public class WebHelper extends AbstractVertxWebHelper { private static final WebHelper INSTANCE = new WebHelper(GlobalTracer.requireTracerImpl()); - static final WeakMap requestTransactionMap = WeakConcurrent.buildMap(); + static final WeakMap requestTransactionMap = WeakConcurrentProviderImpl.createWeakSpanMap(); public static WebHelper getInstance() { return INSTANCE; diff --git a/apm-agent-plugins/apm-vertx/apm-vertx3-plugin/src/main/java/co/elastic/apm/agent/vertx/v3/web/http1/HttpServerRequestImplEndInstrumentation.java b/apm-agent-plugins/apm-vertx/apm-vertx3-plugin/src/main/java/co/elastic/apm/agent/vertx/v3/web/http1/HttpServerRequestImplEndInstrumentation.java index 9659e67645..a734acd820 100644 --- a/apm-agent-plugins/apm-vertx/apm-vertx3-plugin/src/main/java/co/elastic/apm/agent/vertx/v3/web/http1/HttpServerRequestImplEndInstrumentation.java +++ b/apm-agent-plugins/apm-vertx/apm-vertx3-plugin/src/main/java/co/elastic/apm/agent/vertx/v3/web/http1/HttpServerRequestImplEndInstrumentation.java @@ -42,7 +42,7 @@ public ElementMatcher getTypeMatcher() { @Override public ElementMatcher getMethodMatcher() { - return named("doEnd").and(takesNoArguments()); + return named("doEnd").or(named("onEnd")).and(takesNoArguments()); } @Override