Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add undici HTTP client instrumentation #2383

Closed
trentm opened this issue Oct 20, 2021 · 4 comments · Fixed by #2858
Closed

add undici HTTP client instrumentation #2383

trentm opened this issue Oct 20, 2021 · 4 comments · Fixed by #2858
Assignees
@trentm
Labels
agent-nodejs Make available for APM Agents project planning. kibana
Projects
APM-Agents (OLD)
Milestone
8.5

Comments

@trentm
Copy link
Member

trentm commented Oct 20, 2021

Add instrumentation support for undici.
@elastic/elasticsearch@8 is (optionally) using it now and it is gaining traction in the community.
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 20, 2021
@mcollina
Copy link

I would recommend using https://github.com/nodejs/undici/blob/main/docs/api/DiagnosticsChannel.md for instrumenting. This will avoid most of the monkeypatching.

@trentm
Copy link
Member Author

trentm commented Oct 20, 2021

@mcollina Thanks! Your GitHub-notification-fu is strong. :) @delvedor Has been encouraging and suggesting diagnostics_channel as well.

@mcollina
Copy link

It's all @delvedor fault!

@trentm trentm mentioned this issue Oct 21, 2021
Closed
@delvedor delvedor mentioned this issue Nov 28, 2021
Closed
@trentm trentm added the kibana label Dec 6, 2021
@estolfo estolfo added this to the 8.1 milestone Jan 24, 2022
@estolfo estolfo removed this from the 8.1 milestone Jan 24, 2022
@trentm trentm mentioned this issue Apr 20, 2022
Closed
@estolfo estolfo added this to the 8.4 milestone Jun 1, 2022
@trentm trentm self-assigned this Jul 26, 2022
@trentm trentm moved this from Planned to In Progress in APM-Agents (OLD) Jul 26, 2022
@trentm trentm modified the milestones: 8.4, 8.5 Jul 28, 2022
trentm added a commit that referenced this issue Aug 4, 2022
@trentm
feat: undici and fetch() instrumentation
88a3c20 
Closes: #2383
@trentm trentm mentioned this issue Aug 4, 2022
Merged
@trentm
Copy link
Member Author

trentm commented Aug 4, 2022

Here is a trace of a small undici-using script that makes four calls to a local HTTP server, using pipelining: 2:

Screen Shot 2022-08-04 at 2 54 49 PM

APM-Agents (OLD) automation moved this from In Progress to Done Aug 11, 2022
n-e pushed a commit to keplr-team/apm-agent-nodejs that referenced this issue Aug 12, 2022
@trentm
feat: undici and fetch() instrumentation (elastic#2858)
6939c03 
Instrument the undici HTTP client library and Node's core `fetch()`.

Closes: elastic#2383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning. kibana
Projects
APM-Agents (OLD)
  
Done
Milestone
8.5
Development

Successfully merging a pull request may close this issue.

feat: undici and fetch() instrumentation elastic/apm-agent-nodejs
4 participants
@trentm @mcollina @estolfo @AlexanderWert