New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "tracestate" parsing must allow whitespace around list-members #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://w3c.github.io/trace-context/#tracestate-header-field-values the tracestate header can have whitespace around list-members. E.g. 'vendor1=foo, vendor2=bar ,\t vendor3=baz ' Refs: elastic/apm-agent-rum-js#1334
🌐 Coverage report
|
basepi
reviewed
Jan 26, 2023
basepi
approved these changes
Jan 26, 2023
@trentm it won't let me ask you for review since you're the author...what do you think of my changes? |
@basepi Should I merge this? Or should there be a changelog entry or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://w3c.github.io/trace-context/#tracestate-header-field-values
the tracestate header can have whitespace around list-members. E.g.
'vendor1=foo, vendor2=bar ,\t vendor3=baz '
Refs: elastic/apm-agent-rum-js#1334
I'm fairly confident on the regex changes, but not at all on possible wider impact. I haven't followed closely how
_parse_tracestate
is used in the agent code.