Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "tracestate" parsing must allow whitespace around list-members #1728

Merged
merged 8 commits into from Jan 27, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 25, 2023

Per https://w3c.github.io/trace-context/#tracestate-header-field-values
the tracestate header can have whitespace around list-members. E.g.
'vendor1=foo, vendor2=bar ,\t vendor3=baz '

Refs: elastic/apm-agent-rum-js#1334


I'm fairly confident on the regex changes, but not at all on possible wider impact. I haven't followed closely how _parse_tracestate is used in the agent code.

Per https://w3c.github.io/trace-context/#tracestate-header-field-values
the tracestate header can have whitespace around list-members. E.g.
    'vendor1=foo, vendor2=bar ,\t vendor3=baz '

Refs: elastic/apm-agent-rum-js#1334
@trentm trentm requested a review from basepi January 25, 2023 23:22
@trentm trentm self-assigned this Jan 25, 2023
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Jan 25, 2023
@apmmachine
Copy link
Collaborator

apmmachine commented Jan 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-01-27T22:18:15.936+0000

  • Duration: 19 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 5081
Skipped 3679
Total 8760

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Collaborator

apmmachine commented Jan 25, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (73/73) 💚
Files 100.0% (241/241) 💚
Classes 100.0% (241/241) 💚
Lines 91.92% (18747/20395) 👍 0.005
Conditionals 75.007% (2878/3837) 👍 0.052

@basepi
Copy link
Contributor

basepi commented Jan 26, 2023

@trentm it won't let me ask you for review since you're the author...what do you think of my changes?

@trentm
Copy link
Member Author

trentm commented Jan 27, 2023

@basepi Should I merge this? Or should there be a changelog entry or something?
I'm away tomorrow, so feel free to take this one over.

@basepi basepi enabled auto-merge (squash) January 27, 2023 21:57
@basepi basepi merged commit 4cbe4d7 into main Jan 27, 2023
APM-Agents (OLD) automation moved this from In Progress to Done Jan 27, 2023
@basepi basepi deleted the trentm/fix-tracestate-OWS branch January 27, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants