This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Remove ELASTIC_APM_LOG_LEVEL from python tests/apps #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this didn't actually do anything because log_level was not an established config value for the python agent. As of elastic/apm-agent-python#946 this is now a setting in python and it was causing tests to fail due to the way python logging works. This PR cleans up all of those references and will make tests pass.
This was referenced Nov 6, 2020
All uses of this setting use `self.options.get` with a default, so we can remove the default in `argparse`. This allows the python agent to only use this setting if it's explicitly set, which is better for how the python agent's `log_level` works.
basepi
commented
Nov 6, 2020
| @@ -363,7 +363,6 @@ def init_start_parser(self, parser, services, argv=None): | |||
| action="store", | |||
| help="APM log level to use", | |||
| choices=["off", "error", "warn", "info", "debug", "trace"], | |||
| default=DEFAULT_APM_LOG_LEVEL | |||
There was a problem hiding this comment.
All uses of this setting use self.options.get with a default,
so we can remove the default in argparse. This allows the python
agent to only use this setting if it's explicitly set, which is better
for how the python agent's log_level works.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
kuisathaverat
approved these changes
Nov 7, 2020
basepi
added a commit
that referenced
this pull request
Nov 9, 2020
* Fix for argparse.get not using our default * Don't set log_level for python agent in agent.sh * Update .ci/scripts/agent.sh Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com> * Lint fixes Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove ELASTIC_APM_LOG_LEVEL from python tests/apps
Why is it important?
Previously, this didn't actually do anything because log_level
was not an established config value for the python agent.
As of elastic/apm-agent-python#946, this is
now a setting in python and it was causing tests to fail due to the
way python logging works. This PR cleans up all of those references
and will make tests pass.
Related issues
elastic/apm-agent-python#946