improved error handling for sync produce #693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruskall
requested changes
Aug 19, 2025
rubvs
commented
Aug 20, 2025
|
|
||
| var wg sync.WaitGroup | ||
| for i := 0; i < 10; i++ { | ||
| for range 10 { |
Contributor
Author
There was a problem hiding this comment.
moderizing. nothing to do with this PR itself.
kruskall
approved these changes
Aug 21, 2025
Member
kruskall
left a comment
kruskall
left a comment
There was a problem hiding this comment.
LGTM, there might be a performance hit due to locking but it's only in the bad case (producing fail) so it's fine IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #513
Improve error handling to
syncproduce.