Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move onboarding document to dedicated index. #1159

Merged
merged 2 commits into from Jul 23, 2018

Conversation

Projects
None yet
4 participants
@simitt
Copy link
Collaborator

commented Jul 19, 2018

Add processor information to onboarding doc and use this to move to its
own index.

implements #1158

@graphaelli I wasn't sure if you were going to touch the onboarding docs in any way when working on #957 so please let me know if this interferes with your plans.

@jalvz also brought up that it might make sense to call it healthcheck instead of onboarding. I am tempted to stick with onboarding as it is unrelated to the actual healthcheck endpoint.

@jalvz

jalvz approved these changes Jul 19, 2018

Copy link
Collaborator

left a comment

I think if it is easier to have 1 thing instead of 2 (onboarding is internal anyways - so just push a healthcheck doc that we will have after #957 instead of having a specific type just for this), we should do it.
In the meanwhile, lgtm

(note: an integration test might break, didn't check)

simitt added some commits Jul 19, 2018

Move onboarding document to dedicated index.
Add processor information to onboarding doc and use this to move to its
own index.

implements #1158

@simitt simitt force-pushed the simitt:move-onboarding-docs branch from bfc691b to ec55c45 Jul 20, 2018

@simitt simitt added this to the 6.4 milestone Jul 23, 2018

@simitt

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 23, 2018

cc @sqren the index will change to "apm-%{[beat.version]}-onboarding-%{+yyyy.MM.dd}"

@simitt simitt merged commit e527b2f into elastic:master Jul 23, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
apm-ci Build finished.
Details

@zube zube bot added [zube]: Done and removed [zube]: In Review labels Jul 23, 2018

simitt added a commit to simitt/apm-server that referenced this pull request Jul 23, 2018

Move onboarding document to dedicated index. (elastic#1159)
* Move onboarding document to dedicated index.

Add processor information to onboarding doc and use this to move to its
own index.

implements elastic#1158
@sqren

This comment has been minimized.

Copy link
Member

commented Jul 23, 2018

@simitt Great, thanks!

simitt added a commit that referenced this pull request Jul 23, 2018

Move onboarding document to dedicated index. (#1159) (#1171)
* Move onboarding document to dedicated index.

Add processor information to onboarding doc and use this to move to its
own index.

implements #1158

@simitt simitt deleted the simitt:move-onboarding-docs branch Aug 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.