Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set more config defaults in code #1494

Merged
merged 2 commits into from Oct 30, 2018
Merged

Conversation

@graphaelli
Copy link
Member

graphaelli commented Oct 29, 2018

Following up on our discussion of setting defaults in code to match the configuration file. I'm still not sure if this is appropriate for a minor release, happy to discuss.

@graphaelli

This comment has been minimized.

Copy link
Member Author

graphaelli commented Oct 29, 2018

This leaves just output.elasticsearch - that one is more tricky, I'm working on it.

@graphaelli

This comment has been minimized.

Copy link
Member Author

graphaelli commented Oct 29, 2018

jenkins, retest this please

@simitt
simitt approved these changes Oct 30, 2018
@roncohen

This comment has been minimized.

Copy link
Collaborator

roncohen commented Oct 30, 2018

@graphaelli

This comment has been minimized.

Copy link
Member Author

graphaelli commented Oct 30, 2018

Sounds good, I'll add that and get this merged in.

@graphaelli graphaelli merged commit b471117 into elastic:master Oct 30, 2018
1 check failed
1 check failed
apm-ci Build finished.
Details
@graphaelli graphaelli deleted the graphaelli:config-defaults branch Oct 30, 2018
graphaelli added a commit to graphaelli/apm-server that referenced this pull request Oct 31, 2018
graphaelli added a commit that referenced this pull request Oct 31, 2018
* set more config defaults in code (#1494)

* adapt test for 6.5
graphaelli added a commit to graphaelli/apm-server that referenced this pull request Oct 31, 2018
* set more config defaults in code (elastic#1494)

* adapt test for 6.x
graphaelli added a commit that referenced this pull request Nov 6, 2018
* set more config defaults in code (#1494)

* adapt test for 6.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.