Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: add span.sync and index field #1548

Merged
merged 3 commits into from Nov 19, 2018
Merged

Conversation

@simitt
Copy link
Collaborator

simitt commented Nov 14, 2018

implements #1523

@simitt

This comment has been minimized.

Copy link
Collaborator Author

simitt commented Nov 14, 2018

jenkins, retest this please

@graphaelli

This comment has been minimized.

Copy link
Member

graphaelli commented Nov 19, 2018

I think a changelog entry would be appropriate for this field addition.

simitt added 3 commits Nov 14, 2018
implements #1523
@simitt simitt force-pushed the simitt:1523-add-span-sync branch from c932963 to 18c1232 Nov 19, 2018
@simitt simitt merged commit b69b827 into elastic:master Nov 19, 2018
2 checks passed
2 checks passed
CLA Commit author is a member of Elasticsearch
Details
apm-ci Build finished.
Details
@zube zube bot added [zube]: Done and removed [zube]: In Review labels Nov 19, 2018
graphaelli added a commit to graphaelli/apm-server that referenced this pull request Nov 28, 2018
* spec: add span.sync and index field

implements elastic#1523
graphaelli added a commit that referenced this pull request Nov 28, 2018
* spec: add span.sync and index field

implements #1523
@simitt simitt deleted the simitt:1523-add-span-sync branch Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.