Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build xpack #1645

Merged
merged 4 commits into from Dec 14, 2018
Merged

Build xpack #1645

merged 4 commits into from Dec 14, 2018

Conversation

@jalvz
Copy link
Collaborator

jalvz commented Dec 12, 2018

No description provided.

jalvz added 2 commits Dec 6, 2018
@jalvz jalvz requested a review from graphaelli Dec 12, 2018
@jalvz

This comment has been minimized.

Copy link
Collaborator Author

jalvz commented Dec 12, 2018

The libbeat side has been merged already.

Rebase, not squash this one.

@jalvz jalvz self-assigned this Dec 12, 2018
Copy link
Member

graphaelli left a comment

looks great, just minor issues

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@jalvz jalvz force-pushed the jalvz:build-xpack branch from 954aa0b to 308fcf0 Dec 13, 2018
@jalvz

This comment has been minimized.

Copy link
Collaborator Author

jalvz commented Dec 13, 2018

only kibana sync failing

@@ -13,6 +13,7 @@ https://github.com/elastic/apm-server/compare/6.5\...master[View commits]
- Use _doc as document type for Elasticsearch >= 7.0.0 https://github.com/elastic/beats/pull/9056[beats/9057].
- Automatically cap signed integers to 63bits https://github.com/elastic/beats/pull/8991[beats/8991].
- Add optional `span.subtype` and `span.action` properties. {pull}1618[1618].
- Build X-Pack binaries. {pull}1645[1645].

This comment has been minimized.

Copy link
@jalvz

jalvz Dec 13, 2018

Author Collaborator

@graphaelli do you think this is appropriate?

This comment has been minimized.

Copy link
@graphaelli

graphaelli Dec 13, 2018

Member

I know what you mean, I can't think of anything better. I'm asking around but I think you're good to merge and we can update the wording later before release so it makes sense to users.

This comment has been minimized.

Copy link
@graphaelli

graphaelli Dec 13, 2018

Member

Build default distribution under the Elastic License

This comment has been minimized.

Copy link
@jalvz

jalvz Dec 14, 2018

Author Collaborator

awesome, many thanks for checking!

Makefile Show resolved Hide resolved
@@ -13,6 +13,7 @@ https://github.com/elastic/apm-server/compare/6.5\...master[View commits]
- Use _doc as document type for Elasticsearch >= 7.0.0 https://github.com/elastic/beats/pull/9056[beats/9057].
- Automatically cap signed integers to 63bits https://github.com/elastic/beats/pull/8991[beats/8991].
- Add optional `span.subtype` and `span.action` properties. {pull}1618[1618].
- Build X-Pack binaries. {pull}1645[1645].

This comment has been minimized.

Copy link
@graphaelli

graphaelli Dec 13, 2018

Member

I know what you mean, I can't think of anything better. I'm asking around but I think you're good to merge and we can update the wording later before release so it makes sense to users.

jalvz added 2 commits Dec 11, 2018
@jalvz jalvz force-pushed the jalvz:build-xpack branch from 84be2bb to 020f044 Dec 14, 2018
@jalvz jalvz merged commit 45c2b0b into elastic:master Dec 14, 2018
1 of 3 checks passed
1 of 3 checks passed
apm-ci Build started for merge commit.
Details
continuous-integration/jenkins/pr-merge This commit is being built
Details
CLA Commit author is a member of Elasticsearch
Details
@zube zube bot added [zube]: Done and removed [zube]: In Review labels Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.