Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent slice out of bounds error #1764

Merged
merged 2 commits into from Jan 11, 2019
Merged

prevent slice out of bounds error #1764

merged 2 commits into from Jan 11, 2019

Conversation

@jalvz
Copy link
Collaborator

jalvz commented Jan 10, 2019

fixes #1760

this can happen eg. if the sourcemap file maps to a different version of the code producing a stacktrace, and the starting line number in the sourcemap is higher than the total line count in the code.

  • needs changelog
  • needs backporting
@jalvz jalvz added this to the 6.6 milestone Jan 10, 2019
@jalvz jalvz self-assigned this Jan 10, 2019
@simitt
simitt approved these changes Jan 11, 2019
@jalvz jalvz merged commit ea24441 into elastic:master Jan 11, 2019
1 of 3 checks passed
1 of 3 checks passed
apm-ci Build started for merge commit.
Details
continuous-integration/jenkins/pr-merge This commit is being built
Details
CLA Commit author is a member of Elasticsearch
Details
@zube zube bot added [zube]: Done and removed [zube]: In Review labels Jan 11, 2019
jalvz added a commit to jalvz/apm-server that referenced this pull request Jan 11, 2019
fixes elastic#1760
jalvz added a commit to jalvz/apm-server that referenced this pull request Jan 11, 2019
fixes elastic#1760
jalvz added a commit that referenced this pull request Jan 11, 2019
jalvz added a commit that referenced this pull request Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.