Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction type to error data #1781

Merged
merged 2 commits into from Jan 15, 2019

Conversation

@jalvz
Copy link
Collaborator

jalvz commented Jan 14, 2019

@jalvz jalvz added this to the 6.6 milestone Jan 14, 2019
@jalvz jalvz requested a review from simitt Jan 14, 2019
@jalvz jalvz modified the milestones: 6.6, 7.0 Jan 14, 2019
@simitt
simitt approved these changes Jan 14, 2019
@@ -181,9 +183,12 @@ func (e *Event) Transform(tctx *transform.Context) []beat.Event {
tctx.Metadata.Merge(fields)
utility.Add(fields, "context", e.Context)

if e.TransactionSampled != nil || (e.TransactionId != nil && *e.TransactionId != "") {
// sampled is nil if an error happens outside a transaction or an (old) agent is not sending sampled info

This comment has been minimized.

Copy link
@simitt

simitt Jan 14, 2019

Collaborator

nice! Could you also add that transaction_type is nil for the same reasons.

@jalvz jalvz merged commit 81beb23 into elastic:master Jan 15, 2019
1 of 3 checks passed
1 of 3 checks passed
apm-ci Build started for merge commit.
Details
continuous-integration/jenkins/pr-merge This commit is being built
Details
CLA Commit author is a member of Elasticsearch
Details
@zube zube bot added [zube]: Done and removed [zube]: In Review labels Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.