Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename transaction span dropped total #1809

Merged

Conversation

@graphaelli
Copy link
Member

graphaelli commented Jan 17, 2019

to be rebase with master, opening early to test a fix in CI infra

resolves #1675

graphaelli added 9 commits Jan 11, 2019
also defines all supported container.* and kubernetes.* now that libbeat can support it, to clean
up tests and customize field descriptions
 Conflicts:
	include/fields.go
	model/metadata/metadata.go
	processor/stream/package_tests/metadata_attrs_test.go
	processor/stream/package_tests/span_attrs_test.go
	testdata/intake-v2/errors.ndjson
	testdata/intake-v2/transactions.ndjson
	testdata/intake-v2/transactions_spans.ndjson
 Conflicts:
	include/fields.go
@jalvz
jalvz approved these changes Jan 17, 2019
@graphaelli

This comment has been minimized.

Copy link
Member Author

graphaelli commented Jan 17, 2019

jenkins, retest this please

@graphaelli

This comment has been minimized.

Copy link
Member Author

graphaelli commented Jan 17, 2019

sync job failed, will follow up with an update as we have a bunch of these lined up.

@graphaelli graphaelli changed the title Rename transaction dropped total Rename transaction span dropped total Jan 17, 2019
@graphaelli graphaelli merged commit e117ca8 into elastic:master Jan 17, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
apm-ci Build finished.
Details
CLA Commit author has signed the CLA
Details
@graphaelli graphaelli deleted the graphaelli:rename-transaction-dropped-total branch Jan 17, 2019
simitt added a commit to simitt/kibana that referenced this pull request Jan 21, 2019
Rename `span.hex_id` and `transaction.span_count.dropped`
related to elastic/apm-server#1809
related to elastic/apm-server#1811
simitt added a commit to simitt/kibana that referenced this pull request Jan 21, 2019
Rename `span.hex_id` and `transaction.span_count.dropped`
related to elastic/apm-server#1809
related to elastic/apm-server#1811
simitt added a commit to elastic/kibana that referenced this pull request Jan 21, 2019
Rename `span.hex_id` and `transaction.span_count.dropped`
related to elastic/apm-server#1809
related to elastic/apm-server#1811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.