Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move beat.version to observer.version #1848

Merged
merged 4 commits into from Jan 29, 2019

Conversation

@simitt
Copy link
Collaborator

simitt commented Jan 28, 2019

fixes #1824

Once this is approved, I can update the docs in beats for the change.

fixes #1824
_meta/fields.common.yml Outdated Show resolved Hide resolved
_meta/fields.common.yml Outdated Show resolved Hide resolved
Copy link
Member

bmorelli25 left a comment

A few changes need to be made for this to render correctly for all. See my comments below. This should prevent adding any new if blocks in the beat documentation! Let me know if you have questions :)

docs/copied-from-beats/outputconfig.asciidoc Outdated Show resolved Hide resolved
docs/copied-from-beats/outputconfig.asciidoc Outdated Show resolved Hide resolved
docs/copied-from-beats/outputconfig.asciidoc Outdated Show resolved Hide resolved
Copy link
Member

bmorelli25 left a comment

Nice!

@simitt

This comment has been minimized.

Copy link
Collaborator Author

simitt commented Jan 29, 2019

jenkins, retest this please

@simitt simitt merged commit c11039e into elastic:master Jan 29, 2019
2 of 3 checks passed
2 of 3 checks passed
apm-ci Build finished.
Details
CLA Commit author is a member of Elasticsearch
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@bmorelli25

This comment has been minimized.

Copy link
Member

bmorelli25 commented Jan 29, 2019

PR opened in beats repo: elastic/beats#10416

@simitt simitt deleted the simitt:1824-update-beats-version branch Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.