Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable overwriting ingest pipelines by default. #2452

Merged
merged 4 commits into from Jul 15, 2019

Conversation

@simitt
Copy link
Collaborator

simitt commented Jul 12, 2019

fixes #2440
Reverting changes from #2273.

Needs to be backported until 7.2

@simitt simitt requested a review from graphaelli Jul 12, 2019
@simitt simitt self-assigned this Jul 12, 2019
Copy link
Member

graphaelli left a comment

add some suggestions but lgtm

changelogs/7.2.asciidoc Outdated Show resolved Hide resolved
tests/system/test_pipelines.py Outdated Show resolved Hide resolved
simitt and others added 2 commits Jul 12, 2019
Co-Authored-By: Gil Raphaelli <g@raphaelli.com>
Co-Authored-By: Gil Raphaelli <g@raphaelli.com>
@graphaelli

This comment has been minimized.

Copy link
Member

graphaelli commented Jul 12, 2019

jenkins, run the tests please

1 similar comment
@graphaelli

This comment has been minimized.

Copy link
Member

graphaelli commented Jul 12, 2019

jenkins, run the tests please

@simitt simitt merged commit 8c01b8f into elastic:master Jul 15, 2019
12 of 13 checks passed
12 of 13 checks passed
Integration Tests Integration Tests failure
Details
Build - Linux Build - Linux passed
Details
Build - Windows Build - Windows passed
Details
CLA All commits in pull request signed
Details
First time contributor
Details
Intake Intake passed
Details
Release Release passed
Details
Sync Kibana Sync Kibana passed
Details
System Tests System Tests passed
Details
Test - Windows Test - Windows passed
Details
Unit Tests Unit Tests passed
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
elasticsearch-ci/docs-build Build finished.
Details
@zube zube bot added [zube]: Done and removed [zube]: In Review labels Jul 15, 2019
simitt added a commit to simitt/apm-server that referenced this pull request Jul 15, 2019
simitt added a commit to simitt/apm-server that referenced this pull request Jul 15, 2019
simitt added a commit to simitt/apm-server that referenced this pull request Jul 15, 2019
simitt added a commit that referenced this pull request Jul 15, 2019
fixes #2440
simitt added a commit that referenced this pull request Jul 15, 2019
fixes #2440
simitt added a commit to simitt/apm-server that referenced this pull request Jul 15, 2019
simitt added a commit that referenced this pull request Jul 16, 2019
* Disable overwriting ingest pipelines by default. (#2452)

fixes #2440
@simitt simitt deleted the simitt:2440-revert-pipeline-overwrite branch Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.