beater/jaeger: introduce "auth_tag" configuration #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduce support for configuring the server to look for a specified Process tag in Jaeger batches, and use the value for authorization. The value is expected to have the same format as HTTP Authorization headers that the Elastic APM agents support. By default Jaeger authorization is disabled, as there is no standard auth tag name.
simitt
reviewed
Feb 26, 2020
- Rename to "apm-server.jaeger.grpc.auth_tag" - Remove auth from HTTP endpoint - Update gRPC endpoint to return "Unauthenticated" code
simitt
approved these changes
Feb 27, 2020
|
Failing system tests are the ones I fixed in another PR - merging. |
axw
added a commit
to axw/apm-server
that referenced
this pull request
Feb 27, 2020
* beater/jaeger: introduce "auth_tag" configuration We introduce support for configuring the server to look for a specified Process tag in Jaeger gRPC batches, and use the value for authorization. The value is expected to have the same format as HTTP Authorization headers that the Elastic APM agents support. By default Jaeger authorization is disabled, as there is no standard auth tag name. This configuration only applies to gRPC, and not HTTP, as Jaeger clients do not support TLS/HTTPS.
|
@bmorelli25 forgot to ask you to review the docs, sorry. Can you please take a look, and feel free to make adjustments. |
axw
added a commit
that referenced
this pull request
Feb 27, 2020
* beater/jaeger: introduce "auth_tag" configuration We introduce support for configuring the server to look for a specified Process tag in Jaeger gRPC batches, and use the value for authorization. The value is expected to have the same format as HTTP Authorization headers that the Elastic APM agents support. By default Jaeger authorization is disabled, as there is no standard auth tag name. This configuration only applies to gRPC, and not HTTP, as Jaeger clients do not support TLS/HTTPS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
We introduce support for configuring the server to look for a specified Process tag in Jaeger batches, and use the value for authorization. The value is expected to have the same format as HTTP authorization headers that the Elastic APM agents support. By default Jaeger authorization is disabled, as there is no standard auth tag name.
This enables token-based auth as an alternative to client certificate auth.
Note for reviewers: an alternative approach to configuration would be to have a hard-coded auth tag, like "elastic_auth", and have that enabled by default (or enabled with a boolean). Since token-based auth isn't a native feature of Jaeger clients/agents, I thought it might be a bit non-intuitive, hence why I made it opt-in. Let me know what you think.
Checklist
make check-fullfor static code checks and linting)How to test these changes
apm-server.jaeger.auth_tag: "authorization"apm-server.secret_token: "foo"--agent.tags authorization=foo, run HotRODRelated issues
Closes #3339