include build time and revision in version information #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphaelli
force-pushed
the
build-version
branch
from
84f8f08
to
6f8c7ff
Compare
graphaelli
requested review from
jalvz and
simitt
and removed request for
jalvz
simitt
approved these changes
Dec 13, 2017
graphaelli
force-pushed
the
build-version
branch
from
6f8c7ff
to
e668dc3
Compare
|
opened elastic/beats#5871 |
graphaelli
force-pushed
the
build-version
branch
from
e668dc3
to
e7c085f
Compare
|
@simitt elastic/beats#5871 was merged really quickly - pulled in the beats update here and eliminated the make warning - can you take another look since this changed so much since the initial review? |
simitt
approved these changes
Dec 14, 2017
graphaelli
force-pushed
the
build-version
branch
from
e7c085f
to
a1a552c
Compare
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Dec 15, 2017
elastic#396 introduced a bug where the index name contained invalid characters that were added to the global version.
graphaelli
added a commit
that referenced
this pull request
Dec 15, 2017
#396 introduced a bug where the index name contained invalid characters that were added to the global version.
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Dec 18, 2017
elastic#396 introduced a bug where the index name contained invalid characters that were added to the global version.
|
@andrewkroh I wonder if we should add this as part of libbeat especially with elastic/beats#5946 in mind? |
|
Yes, I think we should have this in libbeat so that it becomes part of every Beat. I'd really like to have this available info in the logs and with |
|
@graphaelli Interested to contribute this back to beats? |
|
@ruflin sure, on it. |
|
elastic/beats#5973 opened for that @andrewkroh / @ruflin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #375, results in:
Hook up to HTTP in #395 can happen after this is in.
note: this does add a make warning:
I'm investigating whether we can get support upstream for
GOBUILD_FLAGSor similar