Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not strip leading 0s from traceIds and spanIds if the span source is jaeger #4671

Merged
merged 2 commits into from Feb 2, 2021
Merged

Do not strip leading 0s from traceIds and spanIds if the span source is jaeger #4671

merged 2 commits into from Feb 2, 2021

Conversation

tobiasstadler
Copy link
Contributor

Fixes #4661

…is Jaeger. Jager is in the process of doing the same.
@apmmachine
Copy link
Collaborator

apmmachine commented Feb 1, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #4671 updated

    • Start Time: 2021-02-02T07:02:57.982+0000
  • Duration: 31 min 52 sec

  • Commit: e54c9f2

Test stats 🧪

Test Results
Failed 0
Passed 4361
Skipped 123
Total 4484

Steps errors 3

Expand to view the steps failures

Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage
Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
Test Sync
  • Took 3 min 27 sec . View more details on here
  • Description: ./.ci/scripts/sync.sh

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you!

@axw
Copy link
Member

axw commented Feb 2, 2021

jenkins run the tests please

@axw
Copy link
Member

axw commented Feb 2, 2021

@tobiasstadler can you please add an entry to changelogs/head.asciidoc, under "Breaking changes"?

@tobiasstadler
Copy link
Contributor Author

@tobiasstadler can you please add an entry to changelogs/head.asciidoc, under "Breaking changes"?

done

@axw axw merged commit 62f3ed6 into elastic:master Feb 2, 2021
axw pushed a commit to axw/apm-server that referenced this pull request Feb 18, 2021
…is jaeger (elastic#4671)

* Do not strip leading 0s from traceIds and spanIds if the span source is Jaeger. Jager is in the process of doing the same.

* Added Jaeger trace/span id formatting change to changelog
# Conflicts:
#	changelogs/head.asciidoc
axw added a commit that referenced this pull request Feb 18, 2021
…is jaeger (#4671) (#4801)

* Do not strip leading 0s from traceIds and spanIds if the span source is Jaeger. Jager is in the process of doing the same.

* Added Jaeger trace/span id formatting change to changelog
# Conflicts:
#	changelogs/head.asciidoc

Co-authored-by: Tobias Stadler <ts.stadler@gmx.de>
axw pushed a commit to axw/apm-server that referenced this pull request Feb 19, 2021
…is jaeger (elastic#4671)

* Do not strip leading 0s from traceIds and spanIds if the span source is Jaeger. Jager is in the process of doing the same.

* Added Jaeger trace/span id formatting change to changelog
# Conflicts:
#	changelogs/head.asciidoc
axw added a commit that referenced this pull request Feb 19, 2021
…is jaeger (#4671) (#4811)

* Do not strip leading 0s from traceIds and spanIds if the span source is Jaeger. Jager is in the process of doing the same.

* Added Jaeger trace/span id formatting change to changelog
# Conflicts:
#	changelogs/head.asciidoc

Co-authored-by: Tobias Stadler <ts.stadler@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger does not strip 0 from trace/span IDs anlylonger
3 participants