Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test default configurations #45

Merged
merged 1 commit into from Oct 17, 2016

Conversation

Projects
None yet
3 participants
@tsg
Copy link
Contributor

commented Oct 12, 2016

Now that we can easily overwrite config settings with -E, we can use the
default configs in the packaging tests. This has the advantage that we test the
default configuration files.

This PR does this for Linux and Darwin. For Windows we need a slightly
different approach, because the tests start the beats as services, so we don't
control the flags.

Test default configurations
Now that we can easily overwrite config settings with -E, we can use the
default configs in the packaging tests. This has the advantage that we test the
default configuration files.

This PR does this for Linux and Darwin. For Windows we need a slightly
different approach, because the tests start the beats as services, so we don't
control the flags.

@tsg tsg added the review label Oct 12, 2016

@ruflin

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2016

Nice. LGTM. Not sure why the Jenkins build seems to be stuck / not starting.

@monicasarbu monicasarbu merged commit 67f0b8a into elastic:master Oct 17, 2016

1 check passed

default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.