From 79d5b0ae5b63fcae9d34131b9d88eb110f8dd3bf Mon Sep 17 00:00:00 2001 From: Dan Kortschak Date: Thu, 9 May 2024 07:05:30 +0930 Subject: [PATCH] address pr comments --- x-pack/filebeat/docs/inputs/input-http-endpoint.asciidoc | 2 ++ x-pack/filebeat/input/http_endpoint/ack.go | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/x-pack/filebeat/docs/inputs/input-http-endpoint.asciidoc b/x-pack/filebeat/docs/inputs/input-http-endpoint.asciidoc index 9a235f310768..66d0281e1e88 100644 --- a/x-pack/filebeat/docs/inputs/input-http-endpoint.asciidoc +++ b/x-pack/filebeat/docs/inputs/input-http-endpoint.asciidoc @@ -379,10 +379,12 @@ observe the activity of the input. | `api_errors_total` | Number of API errors. | `batches_received_total` | Number of event arrays received. | `batches_published_total` | Number of event arrays published. +| `batches_acked_total` | Number of event arrays ACKed. | `events_published_total` | Number of events published. | `size` | Histogram of request content lengths. | `batch_size` | Histogram of the received event array length. | `batch_processing_time` | Histogram of the elapsed successful batch processing times in nanoseconds (time of receipt to time of ACK for non-empty batches). +| `batch_ack_time` | Histogram of the elapsed successful batch ACKing times in nanoseconds (time of handler start to time of ACK for non-empty batches). |======= [id="{beatname_lc}-input-{type}-common-options"] diff --git a/x-pack/filebeat/input/http_endpoint/ack.go b/x-pack/filebeat/input/http_endpoint/ack.go index aa396deae7d3..9dfc5a656b56 100644 --- a/x-pack/filebeat/input/http_endpoint/ack.go +++ b/x-pack/filebeat/input/http_endpoint/ack.go @@ -47,8 +47,8 @@ func newBatchACKTracker(fn func()) *batchACKTracker { } // Ready signals that the batch has been fully consumed. Only -// after the batch is marked as "ready" can the lumberjack batch -// be ACKed. This prevents the batch from being ACKed prematurely. +// after the batch is marked as "ready" can the batch be ACKed. +// This prevents the batch from being ACKed prematurely. func (t *batchACKTracker) Ready() { t.ACK() }