Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filebeat README has bad links #5710

Closed
markwalkom opened this issue Nov 25, 2017 · 4 comments

Comments

@markwalkom
Copy link
Member

commented Nov 25, 2017

Reported here - https://twitter.com/z3ndrag0n/status/934354610650615808

If you grab https://artifacts.elastic.co/downloads/beats/filebeat/filebeat-6.0.0-darwin-x86_64.tar.gz and extract it, the README.md has 4 links that all 404.

File - https://www.elastic.co/guide/en/beats/filebeat/6/filebeat-getting-started.html
Actual - https://www.elastic.co/guide/en/beats/filebeat/6.0/filebeat-getting-started.html

Basically, all 3 links need a .0 added to specifically point them to 6.0 docs.

I wasn't sure how this was generated, ie if it was automatic, so didn't want to make a PR against the file.

@markwalkom markwalkom added the docs label Nov 25, 2017
@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Nov 27, 2017

The file is generated out of https://github.com/elastic/beats/blob/master/dev-tools/packer/readme.md.j2 and it should contain the value from here: https://github.com/elastic/beats/blob/6.0/libbeat/docs/version.asciidoc#L2 (which is 6.0). I need to investigate was is going wrong here during packaging.

@ruflin ruflin added the libbeat label Nov 27, 2017
@dedemorton

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2017

In the mean time, I've asked the web team to set up a redirect. Let me know if there are any other broken URLs in the readme files, and we can set up redirects for those, too.

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Nov 27, 2017

I opened #5715 against 6.0. The issue is that gotpl convert 6.0 to 6, that is why we have the issue only with all first major version and we never had it in the past, as we didn't have that script yet for 5.0. Still doing some testing to see if the fix works as expected.

@dedemorton

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2018

Closing this issue because it was fixed in #5715 plus I've had redirects set up.

@dedemorton dedemorton closed this Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.