Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the Windows module GA #10163

Merged
merged 5 commits into from Jan 21, 2019

Conversation

@ruflin
Copy link
Collaborator

ruflin commented Jan 18, 2019

The perfmon metricset is still in Beta. There are a few improvements I would like to see like #6584 before pushing this to GA. These changes could be breaking changes.

The perfmon metricset is still in Beta. There are a few improvements I would like to see like #6584 before pushing this to GA. These changes could be breaking changes.
@ruflin ruflin self-assigned this Jan 18, 2019
@ruflin ruflin requested review from elastic/beats as code owners Jan 18, 2019
@ruflin ruflin requested a review from elastic/uptime as a code owner Jan 18, 2019
@jsoriano jsoriano added the blocked label Jan 18, 2019
ruflin added 3 commits Jan 21, 2019
@jsoriano

This comment has been minimized.

Copy link
Member

jsoriano commented Jan 21, 2019

I added the blocked tag to avoid merging it if we consider that we want #6584 and we think this may be a breaking change.

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

ruflin commented Jan 21, 2019

The perfmon metricset is still in beta, only the service metricset it release as GA.

Copy link
Member

jsoriano left a comment

Ok to make only the service metricset GA by now.

@ruflin ruflin merged commit dbfa3ef into elastic:master Jan 21, 2019
5 checks passed
5 checks passed
CLA Commit author has signed the CLA
Details
Hound No violations found. Woof!
beats-ci Build finished.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin ruflin deleted the ruflin:windows-ga branch Jan 21, 2019
ruflin added a commit to ruflin/beats that referenced this pull request Jan 21, 2019
The perfmon metricset is still in Beta. There are a few improvements I would like to see like elastic#6584 before pushing this to GA. These changes could be breaking changes.

(cherry picked from commit dbfa3ef)
@ruflin ruflin added v6.7.0 and removed needs_backport labels Jan 21, 2019
ruflin added a commit that referenced this pull request Jan 22, 2019
The perfmon metricset is still in Beta. There are a few improvements I would like to see like #6584 before pushing this to GA. These changes could be breaking changes.

(cherry picked from commit dbfa3ef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.