Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winlogbeat Fix an issue with caching #1100

Merged
merged 1 commit into from Mar 3, 2016

Conversation

Projects
None yet
2 participants
@andrewkroh
Copy link
Member

commented Mar 3, 2016

  • Fix an issue with caching (an unreleased feature) that was introduced in #888
  • Add expvar metrics for the event message file cache (hits/misses/size)
  • Add strict validation for top-level YAML keys in winlogbeat config

Example expvar cache metrics are shown below. I just wanted to make the cache a bit more "observable" for the debugging purposes.

...
"msgFileCacheStats": {"ApplicationHits": 48808, "ApplicationMisses": 4, "ApplicationSize": 0, "SecurityHits": 1378, "SecurityMisses": 2, "SecuritySize": 0, "SetupMisses": 1, "SetupSize": 0},
...
Fix an issue with caching from #888.
Add expvar metrics for the cache (hits/misses/size).
Add strict validation for top-level YAML keys in winlogbeat config.
// Validate validates the Settings data and returns an error describing
// all problems or nil if there are none.
func (s Settings) Validate() error {
validKeys := []string{"winlogbeat", "output", "shipper", "logging"}

This comment has been minimized.

Copy link
@ruflin

ruflin Mar 3, 2016

Collaborator

That looks like something we should move to libbeat, as these 4 keys must exist for each beat.

ruflin added a commit that referenced this pull request Mar 3, 2016

@ruflin ruflin merged commit f814a02 into elastic:master Mar 3, 2016

4 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Merged build finished.
Details

@andrewkroh andrewkroh deleted the andrewkroh:bugfix/wlb-cache-stats-config branch Mar 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.