Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #11006 to 5.6: [Winlogbeat] Prevent Winlogbeat from dropping events with invalid XML #11066

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@andrewkroh
Copy link
Member

commented Mar 4, 2019

Cherry-pick of PR #11006 to 5.6 branch. Original message:

Golang's xml parser is refusing to process XML documents that contain an ASCII control character, resulting in those events being dropped. This patch pre-processes the XML document in order to replace invalid characters with the unicode escape sequence \uNNNN.

[Winlogbeat] Prevent Winlogbeat from dropping events with invalid XML (
…#11006)

* [Winlogbeat] Escape control characters in XML

Golang's xml parser is pretty strict about the presence of control
characters in the XML it is fed. This patch replaces those characters
with an unicode escape sequence: "\uNNNN".

(cherry picked from commit a6102a8)

@adriansr adriansr requested review from adriansr and removed request for adriansr Mar 4, 2019

@andrewkroh andrewkroh merged commit 1aa1b17 into elastic:5.6 Mar 4, 2019

2 of 4 checks passed

beats-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
CLA All commits in pull request signed
Details
Hound No violations found. Woof!

@andrewkroh andrewkroh deleted the andrewkroh:backport_11006_5.6 branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.