Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure topbeat to make functions available as library #1172

Merged
merged 1 commit into from Mar 21, 2016

Conversation

Projects
None yet
3 participants
@ruflin
Copy link
Collaborator

commented Mar 16, 2016

Topbeat has lots of functionality which can be reused in other libraries, especially topbeat. To decouple the functionality from topbeat, this PR restructures Topbeat into the beater part and the library part. This makes is possible to reuse and share the functionality between Topbeat and Metricbeat.

Further steps should be taken later to also better split up the testing and introduce ucfg in topbeat.

This refactoring did not change any functionality or output of topbeat.

@tsg

This comment has been minimized.

Copy link
Collaborator

commented Mar 16, 2016

Not directly related to the PR, but it would be time to update the new Beat dev guide. It's using Topbeat so this will make it even more outdated, but we'd anyway have to speak about the generator, about the single repo, etc.

OTOH, the guide doesn't really seem to be required :-).

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 17, 2016

@tsg Fully agree for the Dev Guide. Needs urgently an update / restructuring. I think it needs to be less focused on the first step of creating the beat, but then how to proceed from there. What are sync / async publisher, how to use ucfg etc.

@ruflin ruflin force-pushed the ruflin:topbeat-library branch from 27ca317 to bc78c72 Mar 17, 2016

@@ -0,0 +1,19 @@
package system

This comment has been minimized.

Copy link
@monicasarbu

monicasarbu Mar 18, 2016

Contributor

I am not sure if sigar.go is the best name for this file especially after you split the sigar functions into multiple dedicated files. As it contains for now only Round function, I would go for common.go and it can be considered the place for all the common system functions.

This comment has been minimized.

Copy link
@ruflin

ruflin Mar 18, 2016

Author Collaborator

I renamed it to common.go

@@ -1,6 +1,6 @@
// +build !integration

This comment has been minimized.

Copy link
@monicasarbu

monicasarbu Mar 18, 2016

Contributor

Wouldn't make sense to split the unit tests to multiple files as well, like system_test, process_test & filesystem_test?

This comment has been minimized.

Copy link
@ruflin

ruflin Mar 18, 2016

Author Collaborator

Yes, I now also splitted up the tests.

@monicasarbu monicasarbu referenced this pull request Mar 18, 2016

Closed

Update Developer Guide #1077

1 of 5 tasks complete
@monicasarbu

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2016

LGTM

@monicasarbu

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2016

@ruflin Please rebase to master, so I can easily merge it.

Restructure topbeat to make functions available as library
Topbeat has lots of functionality which can be reused in other libraries, especially topbeat. To decouple the functionality from topbeat, this PR restructures Topbeat into the beater part and the library part. This makes is possible to reuse and share the functionality between Topbeat and Metricbeat.

Further steps should be taken later to also better split up the testing and introduce ucfg in topbeat.

This refactoring did not change any functionality or output of topbeat.

@ruflin ruflin force-pushed the ruflin:topbeat-library branch from bc78c72 to 9f46265 Mar 18, 2016

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 18, 2016

@monicasarbu Rebase done and newest version pushed.

@monicasarbu

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2016

@ruflin Great, thanks

monicasarbu added a commit that referenced this pull request Mar 21, 2016

Merge pull request #1172 from ruflin/topbeat-library
Restructure topbeat to make functions available as library

@monicasarbu monicasarbu merged commit e9eaddc into elastic:master Mar 21, 2016

3 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ruflin ruflin deleted the ruflin:topbeat-library branch Mar 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.