New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade elasticsearch templates so that they are compliant with the upcoming elasticsearch 5.0. #1221

Merged
merged 1 commit into from Mar 29, 2016

Conversation

Projects
None yet
3 participants
@jpountz
Contributor

jpountz commented Mar 24, 2016

Elasticsearch 5.0 has refactored mappings as described in
elastic/elasticsearch#12394. Most notably the string field has been replaced
by the text and keyword fields.

Upgrade elasticsearch templates so that they are compliant with the u…
…pcoming elasticsearch 5.0.

Elasticsearch 5.0 has refactored mappings as described in
elastic/elasticsearch#12394. Most notably the string field has been replaced
by the `text` and `keyword` fields.
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Mar 24, 2016

Collaborator

@jpountz Thanks a lot for the contribution. I saw you updated the generation script, so I assume all the template files are generated automatically based on this?

Collaborator

ruflin commented Mar 24, 2016

@jpountz Thanks a lot for the contribution. I saw you updated the generation script, so I assume all the template files are generated automatically based on this?

@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Mar 24, 2016

Contributor

@ruflin Indeed I used the script to regenerate the templates.

Contributor

jpountz commented Mar 24, 2016

@ruflin Indeed I used the script to regenerate the templates.

@tsg tsg added the review label Mar 24, 2016

@tsg

This comment has been minimized.

Show comment
Hide comment
@tsg

tsg Mar 24, 2016

Collaborator

I tested Topbeat, Packetbeat and Filebeat and they all seem to work fine. The travis fail is because of the LS plugin, so not related.

However, I'm going to sit on this at least until our team meeting today, because we probably will want to keep the old templates around, so that Beats 5.0 work with ES < 5.0.

Collaborator

tsg commented Mar 24, 2016

I tested Topbeat, Packetbeat and Filebeat and they all seem to work fine. The travis fail is because of the LS plugin, so not related.

However, I'm going to sit on this at least until our team meeting today, because we probably will want to keep the old templates around, so that Beats 5.0 work with ES < 5.0.

@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Mar 25, 2016

Contributor

However, I'm going to sit on this at least until our team meeting today, because we probably will want to keep the old templates around, so that Beats 5.0 work with ES < 5.0.

Something to be careful with is that it means that Beats 5.0 will not be compatible with Elasticsearch 6.0.

Would it be possible for Beats to load a different template based on the version of the elasticsearch cluster that it connects to?

Contributor

jpountz commented Mar 25, 2016

However, I'm going to sit on this at least until our team meeting today, because we probably will want to keep the old templates around, so that Beats 5.0 work with ES < 5.0.

Something to be careful with is that it means that Beats 5.0 will not be compatible with Elasticsearch 6.0.

Would it be possible for Beats to load a different template based on the version of the elasticsearch cluster that it connects to?

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Mar 27, 2016

Collaborator

@jpountz Potentially possible to load different templates for different ES version. We still have to solve the problem of versioning templates for different beats versions and then should also take this one into account.

Collaborator

ruflin commented Mar 27, 2016

@jpountz Potentially possible to load different templates for different ES version. We still have to solve the problem of versioning templates for different beats versions and then should also take this one into account.

@tsg tsg merged commit a5cd423 into elastic:master Mar 29, 2016

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
CLA Commit author is a member of Elasticsearch
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
default Merged build finished.
Details
@tsg

This comment has been minimized.

Show comment
Hide comment
@tsg

tsg Mar 29, 2016

Collaborator

We decided in the meeting that we want to go with the new templates only, because we only aim to work with the previous version of ES for the purpose of upgrading, in which case the templates are already loaded.

So I'm simply merging this one, thanks @jpountz.

Collaborator

tsg commented Mar 29, 2016

We decided in the meeting that we want to go with the new templates only, because we only aim to work with the previous version of ES for the purpose of upgrading, in which case the templates are already loaded.

So I'm simply merging this one, thanks @jpountz.

@jpountz jpountz deleted the jpountz:upgrade_templates branch Mar 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment