Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log error (don't also index it) if xpack is enabled. #12353

Merged
merged 2 commits into from May 31, 2019

Conversation

@ycombinator
Copy link
Contributor

ycombinator commented May 29, 2019

When xpack.enabled: true is set on a stack module, the expectation is that the user won't see any metricbeat-* indices. Instead users expect to see .monitoring-* indices.

However, metricbeat indexes errors into metricbeat-* indices. So in an error situation when xpack.enabled: true is set, we don't want to index errors but just log them. That's what this PR fixes for the kibana/stats metricset.

Equivalent of #12265 but for 7.1 (see #12265 (comment) for rationale).

@ycombinator ycombinator requested a review from elastic/stack-monitoring as a code owner May 29, 2019
@ycombinator ycombinator requested a review from ruflin May 29, 2019
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented May 29, 2019

@ycombinator ycombinator force-pushed the ycombinator:mb-kb-only-log-error-xp-71 branch from 52d471a to c3024eb May 31, 2019
@ycombinator ycombinator merged commit 7f0ac09 into elastic:7.1 May 31, 2019
4 checks passed
4 checks passed
CLA All commits in pull request signed
Details
Hound No violations found. Woof!
beats-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ycombinator added a commit to ycombinator/beats that referenced this pull request May 31, 2019
)

* Only log error (don't also index it) if xpack is enabled.

* Adding CHANGELOG entry
ycombinator added a commit that referenced this pull request Jun 3, 2019
…) (#12379)

* Only log error (don't also index it) if xpack is enabled.

* Adding CHANGELOG entry
@ycombinator ycombinator deleted the ycombinator:mb-kb-only-log-error-xp-71 branch Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.