Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #12741 to 7.2: [Packetbeat] Redis: Limit memory used by replication #12752

Merged
merged 2 commits into from Jul 4, 2019

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Jul 2, 2019

Cherry-pick of PR #12741 to 7.2 branch. Original message:

This patch limits the amount of memory that can be used by outstanding requests by adding two new configuration options to the Redis protocol:

  • max_queue_size: Limits the total size of the queued requests (in bytes).
  • max_queue_length: Limits the number of requests queued.

These limits apply to individual connections. The defaults are to queue up to 1MB or 20.000 requests. This is enough to limit the currently unbounded memory used by replication streams while at the same time allow for pipelining requests.

Closes #12657

This patch limits the amount of memory that can be used by outstanding
requests by adding two new configuration options to the Redis protocol:

- max_queue_size: Limits the total size of the queued requests (in bytes).
- max_queue_length: Limits the number of requests queued.

These limits apply to individual connections. The defaults are to queue
up to 1MB or 20.000 requests. This is enough to limit the currently
unbounded memory used by replication streams while at the same time
allow for pipelining requests.

Closes elastic#12657

(cherry picked from commit 1275ee8)
@adriansr adriansr merged commit 036830f into elastic:7.2 Jul 4, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ed by replication (elastic#12752)

This patch limits the amount of memory that can be used by outstanding
requests by adding two new configuration options to the Redis protocol:

- max_queue_size: Limits the total size of the queued requests (in bytes).
- max_queue_length: Limits the number of requests queued.

These limits apply to individual connections. The defaults are to queue
up to 1MB or 20.000 requests. This is enough to limit the currently
unbounded memory used by replication streams while at the same time
allow for pipelining requests.

Closes elastic#12657

(cherry picked from commit 4d0ea18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants