Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the import/export dashboards scripts to dev-tools #1359

Merged

Conversation

Projects
None yet
2 participants
@monicasarbu
Copy link
Contributor

monicasarbu commented Apr 8, 2016

  • Add bash and powershell script to the beats/dev-tools repo
  • Add script to export the dashboards and its dependencies for a single Beat
  • Add docs

KIBANA_ES?=http://localhost:9200/
.PHONY: update
kibana-export:

This comment has been minimized.

Copy link
@ruflin

ruflin Apr 8, 2016

Collaborator

The idea to have it here was to make it easily available for community beats developers.

This comment has been minimized.

Copy link
@monicasarbu

monicasarbu Apr 8, 2016

Author Contributor

Yes, I will them back in the Makefile once I check the add details about how to use the new script.

@@ -1,47 +0,0 @@
from elasticsearch import Elasticsearch

This comment has been minimized.

Copy link
@ruflin

ruflin Apr 8, 2016

Collaborator

Is this not needed anymore?

This comment has been minimized.

Copy link
@monicasarbu

monicasarbu Apr 8, 2016

Author Contributor

I moved (and adjusted) the bash and powershell scripts in the beat repository, so no need to have another python script to do the same thing.

@monicasarbu monicasarbu force-pushed the monicasarbu:move_import_export_dashboards_scripts branch from 4e68e6d to 0ba4af1 Apr 8, 2016

@monicasarbu monicasarbu added the review label Apr 11, 2016

@monicasarbu monicasarbu force-pushed the monicasarbu:move_import_export_dashboards_scripts branch from 8847c0b to daeafa3 Apr 11, 2016

[[new-dashboards]]
== Developer Guide: Creating new Kibana dashboards

This guide walks you through the steps for creating a new Kibana dashboards

This comment has been minimized.

Copy link
@ruflin

ruflin Apr 11, 2016

Collaborator

We should recommend here to use the virtual environment under testing/environments to create the dashboards. The reasons for this is:

  • People start with an empty Kibana instance
  • Everyone is using the same Kibana version (most recent one)
  • No setup on developer side needed

This should lead to hopefully cleaner dashboards or outdated dashboards.

This comment has been minimized.

Copy link
@monicasarbu

monicasarbu Apr 12, 2016

Author Contributor

That's a good point. I will add it.

# Fixes windows problem with files with * inside
# Adds it to index pattern
if folder == "index-pattern":
type = type + "-*"

This comment has been minimized.

Copy link
@ruflin

ruflin Apr 11, 2016

Collaborator

Do still have this problem? Or is this solved as we have a separate import script for windows?

This comment has been minimized.

Copy link
@monicasarbu

monicasarbu Apr 11, 2016

Author Contributor

I deleted the python script entirely as it's replaced by the bash & powershell script for importing the dashboards to Kibana.

This comment has been minimized.

Copy link
@ruflin

ruflin Apr 12, 2016

Collaborator

I found the answer here: https://github.com/monicasarbu/beats/blob/move_import_export_dashboards_scripts/dev-tools/import_dashboards.ps1#L130

It seems you read now the json content and extract the title from the json document instead of creating it out of the file name.

@ruflin

This comment has been minimized.

Copy link
Collaborator

ruflin commented Apr 11, 2016

LGTM. What happens with the "general" files in libbeat? https://github.com/elastic/beats/tree/master/libbeat/etc/kibana Are these still taken into account or not needed anymore?

@monicasarbu

This comment has been minimized.

Copy link
Contributor Author

monicasarbu commented Apr 11, 2016

@ruflin Good point. I didn't notice those from libbeat. I think we can delete the etc/kibana from libbeat as there are no common widgets or searches.

@ruflin

This comment has been minimized.

Copy link
Collaborator

ruflin commented Apr 12, 2016

@monicasarbu Previously we had the Navigation one in all dashboards. So this is not the case anymore?

@monicasarbu

This comment has been minimized.

Copy link
Contributor Author

monicasarbu commented Apr 12, 2016

The Navigation widget should be added only to the Beats that have more than one Kibana dashboard to make it easier to navigate between them.

Move scripts to dev-tools de manage Kibana dashboards
- Add bash/powershell scripts to import and export the dashboards and its
dependencies in Kibana.
- Run `make import-dashboards` in a Beat repository to import all the dashboards and its dependencies from etc/kibana to Elasticsearch
- Run `make export-dashboards` in a Beat repository to export all the dashboards and its dependencies  from etc/kibana to Elasticsearch
- Add documentation
- Update changelog
- Recommend to use testing/environments when creating dashboards.

@monicasarbu monicasarbu force-pushed the monicasarbu:move_import_export_dashboards_scripts branch from 56c8d55 to ef86371 Apr 12, 2016

@monicasarbu

This comment has been minimized.

Copy link
Contributor Author

monicasarbu commented Apr 12, 2016

All the comments are addressed.

@ruflin ruflin merged commit 5cfb20c into elastic:master Apr 13, 2016

4 checks passed

CLA Commit author is a member of Elasticsearch
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.