Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging #1385

Merged
merged 3 commits into from Apr 14, 2016

Conversation

Projects
None yet
2 participants
@tsg
Copy link
Collaborator

commented Apr 13, 2016

This adjusts the paths for DEB and RPM according to the layout set in #1371, using a layout as close as possible as the one used by Elasticsearch.

Also fixes a gem install issue for fpm 1.5.

tsg added some commits Apr 13, 2016

Updated debian packaging to use the new layout
* Follows the layout as defined in #1371, setting path.home, path.config
  and path.data
* This removes the need to adjust the configuration file
@tsg

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 13, 2016

Custom configuration file sedding is no longer needed for the template and the registry file in filebeat. \o/

@tsg tsg added the review label Apr 13, 2016

@tsg tsg referenced this pull request Apr 13, 2016

Closed

Directory layout and data path #1371

14 of 14 tasks complete
- Add scripts for managing the dashboards of a single Beat {pull}1359[1359]
- On DEB/RPM installations, the binary files are now found under `/usr/share/{{beat_name}}/bin`, not in `/usr/bin`. {pull}1385[1385]

This comment has been minimized.

Copy link
@andrewkroh

andrewkroh Apr 13, 2016

Member

Should we symlink the binary? Will that cause problems?

This comment has been minimized.

Copy link
@tsg

tsg Apr 13, 2016

Author Collaborator

Symlinking might be confusing because without the correct -path.* parameters the Beats might behave quite different. An alternative idea is to have, say, a filebeat.sh that runs filebeat with the right parameters in foreground. Not sure how helpful that would be.

This comment has been minimized.

Copy link
@tsg

tsg Apr 14, 2016

Author Collaborator

I added that as a TODO in #1371, I'd prefer getting this one in quicker so we can test it with the nightlies.

@andrewkroh

This comment has been minimized.

Copy link
Member

commented Apr 14, 2016

LGTM

@andrewkroh andrewkroh merged commit 3e06053 into elastic:master Apr 14, 2016

4 checks passed

CLA Commit author is a member of Elasticsearch
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@tsg tsg deleted the tsg:update_packaging branch Aug 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.