Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing calls to service.BeforeRun() and service.Cleanup() #1415

Merged
merged 1 commit into from Apr 19, 2016

Conversation

Projects
None yet
2 participants
@andrewkroh
Copy link
Member

commented Apr 19, 2016

They were dropped during the refactor in #1249.

In a separate PR I'll work on adding a test case to prevent future regressions.

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Apr 19, 2016

LGTM. But seems to need rebase.

Add missing calls to service.BeforeRun() and service.Cleanup().
They were dropped during the refactor in #1249.

@andrewkroh andrewkroh force-pushed the andrewkroh:bugfix/svc-cleanup branch from e722bb8 to 3cbf6b8 Apr 19, 2016

@andrewkroh

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2016

Rebased. Oddly, there were to conflicts so I'm not sure why Github was complaining.

@ruflin ruflin merged commit a0f543d into elastic:master Apr 19, 2016

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@andrewkroh andrewkroh deleted the andrewkroh:bugfix/svc-cleanup branch May 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.