Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanup when autodiscover pods are terminated #14259

Conversation

@jsoriano
Copy link
Member

jsoriano commented Oct 26, 2019

In some cases pods termination doesn't originate a delete event in the
API watchers. Detect termination also by checking if a deletion
timestamp exists in update events.

In some cases pods termination doesn't originate a delete event in the
API watchers. Detect termination also by checking if a deletion
timestamp exists in update events.
jsoriano added 3 commits Oct 26, 2019
@jsoriano jsoriano added the v7.3.3 label Oct 26, 2019
@jsoriano

This comment has been minimized.

Copy link
Member Author

jsoriano commented Oct 26, 2019

Similar change will be needed in add_kubernetes_metadata.

@jsoriano

This comment has been minimized.

Copy link
Member Author

jsoriano commented Oct 27, 2019

Added changes to add_kubernetes_metadata too.

jsoriano added 2 commits Oct 27, 2019
@exekias

This comment has been minimized.

Copy link
Member

exekias commented Oct 28, 2019

very good catch here @jsoriano!

@jsoriano jsoriano merged commit 1c36118 into elastic:master Oct 28, 2019
9 of 10 checks passed
9 of 10 checks passed
beats-ci Build finished.
Details
CLA All commits in pull request signed
Details
Hound No violations found. Woof!
Intake Intake passed
Details
Test Test passed
Details
codecov/patch 0% of diff hit (within 100% threshold of 58.16%)
Details
codecov/project 58.17% (+<.01%) compared to 30e0708
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
elasticsearch-ci/docs Build finished.
Details
@jsoriano jsoriano deleted the jsoriano:kubernetes-autodiscover-handle-pod-termination branch Oct 28, 2019
jsoriano added a commit to jsoriano/beats that referenced this pull request Oct 28, 2019
In some cases pods termination doesn't originate a delete event in the
API watchers. Detect termination also by checking if a deletion
timestamp exists in update events.

(cherry picked from commit 1c36118)
jsoriano added a commit to jsoriano/beats that referenced this pull request Oct 28, 2019
In some cases pods termination doesn't originate a delete event in the
API watchers. Detect termination also by checking if a deletion
timestamp exists in update events.

(cherry picked from commit 1c36118)
jsoriano added a commit that referenced this pull request Oct 28, 2019
…minated (#14265)

In some cases pods termination doesn't originate a delete event in the
API watchers. Detect termination also by checking if a deletion
timestamp exists in update events.

(cherry picked from commit 1c36118)
jsoriano added a commit that referenced this pull request Nov 5, 2019
In some cases pods termination doesn't originate a delete event in the
API watchers. Detect termination also by checking if a deletion
timestamp exists in update events.

(cherry picked from commit 1c36118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.