Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline reader normalizing multiline character #1552

Merged
merged 1 commit into from May 3, 2016

Conversation

Projects
None yet
2 participants
@urso
Copy link
Collaborator

commented May 2, 2016

Multiline reader assumes newline characters already removed. The StripNewLine reader will be applied right before the multiline reader.

@urso urso force-pushed the urso:enh/linereader-newline branch from 8598d3b to 1b228cf May 2, 2016

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2016

@urso Was this a specific bug we had? Worth a system test? Seems to need rebase.

@urso

This comment has been minimized.

Copy link
Collaborator Author

commented May 3, 2016

@ruflin no specific bug. It's preparing for using regexp.Compile instead of regexp.CompilePOSIX in general. When doing the switch the $ operator will not work without this change.

@urso urso force-pushed the urso:enh/linereader-newline branch from 1b228cf to bbf3db2 May 3, 2016

@urso

This comment has been minimized.

Copy link
Collaborator Author

commented May 3, 2016

rebased

@ruflin ruflin merged commit 11291b0 into elastic:master May 3, 2016

4 checks passed

CLA Commit author is a member of Elasticsearch
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@urso urso deleted the urso:enh/linereader-newline branch May 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.